Add DeviceTypeAsString to SyncedSession.

Add DeviceTypeAsString to SyncedSession.

The ForeignSessionHandler should set the deviceType field so icons can
be correctly displayed.

BUG=None
TEST=Device type specific icons should show up on open tabs section of
NTP.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148219

[nyquist, 2012-07-24 06:22:05]

nzea: friendly ping

[Nicolas Zea, 2012-07-24 18:44:23]

Sorry for the delay, I thought this was a review I'd already done. LGTM.

http://codereview.chromium.org/10695192/diff/1/chrome/browser/sync/glue/synce...
File chrome/browser/sync/glue/synced_session.h (right):

http://codereview.chromium.org/10695192/diff/1/chrome/browser/sync/glue/synce...
chrome/browser/sync/glue/synced_session.h:101: return "win";
Not sure in what context these will be displayed, but should they have the first
letter capitalized?

[nyquist, 2012-07-24 20:18:37]

estade: could you please review chrome/browser/ui/webui/ntp ?

nzea: Updated the comment.

http://codereview.chromium.org/10695192/diff/1/chrome/browser/sync/glue/synce...
File chrome/browser/sync/glue/synced_session.h (right):

http://codereview.chromium.org/10695192/diff/1/chrome/browser/sync/glue/synce...
chrome/browser/sync/glue/synced_session.h:101: return "win";
On 2012/07/24 18:44:24, nzea wrote:
> Not sure in what context these will be displayed, but should they have the
first
> letter capitalized?

They are used for matching an icon style on the NTP towards laptop/phone/tablet,
and not visible other than in the NTP source code. I have clarified the comment.

[Evan Stade, 2012-07-24 20:19:14]

lgtm

[commit-bot: I haz the power, 2012-07-24 20:20:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/10695192/6001

[commit-bot: I haz the power, 2012-07-24 22:02:20]

Change committed as 148219