Add support for triggering Android intents based on content.

Add support for triggering Android intents based on content.


BUG=125390
TEST=Chrome on Android UI tests, not ready to be upstreamed yet.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146105

[Leandro Graciá Gil, 2012-07-10 17:54:50]

jrg: all content/public/android Java changes and content/browser/android native
changes, including the JNI stuff.

jam: all other changes in content regarding the new IPC message all the way up
the render view host and render widget host view.

Thanks!

[Leandro Graciá Gil, 2012-07-10 17:56:25]

https://chromiumcodereview.appspot.com/10695124/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
(right):

https://chromiumcodereview.appspot.com/10695124/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java:281:
public void onStartContentIntent(Context context, String contentUrl) {
jrg: this uses a context downstream but was changed by you when first
upstreaming the file. Is there any reason for that? It doesn't seem we need the
full content view object.

[jam, 2012-07-10 21:06:16]

lgtm for my parts with nits

http://codereview.chromium.org/10695124/diff/1/content/browser/renderer_host/...
File content/browser/renderer_host/render_view_host_impl.cc (right):

http://codereview.chromium.org/10695124/diff/1/content/browser/renderer_host/...
content/browser/renderer_host/render_view_host_impl.cc:921:
OnStartContentIntent);
are you sure this doesn't fit on one line?

also get rid of the semicolon

http://codereview.chromium.org/10695124/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

http://codereview.chromium.org/10695124/diff/1/content/common/view_messages.h...
content/common/view_messages.h:2098: GURL /* content URL */)
nit: convention (not followed everywhere, unfortunately) is to put the
dispatcher's parameter name in the comment, i.e. content_url

[John Grabowski, 2012-07-10 22:20:31]

LGTM for */android/*

https://chromiumcodereview.appspot.com/10695124/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
(right):

https://chromiumcodereview.appspot.com/10695124/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java:281:
public void onStartContentIntent(Context context, String contentUrl) {
On 2012/07/10 17:56:25, Leandro Graciá Gil wrote:
> jrg: this uses a context downstream but was changed by you when first
> upstreaming the file. Is there any reason for that? It doesn't seem we need
the
> full content view object.

My best guess is that, at the time I upstreamed it, it was in fact a
ContentView.

[Leandro Graciá Gil, 2012-07-11 10:55:43]

Nits fixed. Thanks for the review!

https://chromiumcodereview.appspot.com/10695124/diff/1/content/browser/render...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10695124/diff/1/content/browser/render...
content/browser/renderer_host/render_view_host_impl.cc:921:
OnStartContentIntent);
On 2012/07/10 21:06:16, John Abd-El-Malek wrote:
> are you sure this doesn't fit on one line?
> 
> also get rid of the semicolon

Done.

https://chromiumcodereview.appspot.com/10695124/diff/1/content/common/view_me...
File content/common/view_messages.h (right):

https://chromiumcodereview.appspot.com/10695124/diff/1/content/common/view_me...
content/common/view_messages.h:2098: GURL /* content URL */)
On 2012/07/10 21:06:16, John Abd-El-Malek wrote:
> nit: convention (not followed everywhere, unfortunately) is to put the
> dispatcher's parameter name in the comment, i.e. content_url

Done.

[commit-bot: I haz the power, 2012-07-11 10:56:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/10695124/1014

[commit-bot: I haz the power, 2012-07-11 11:58:48]

Change committed as 146105