ui/gfx/canvas_win.cc - Issue 10695101: Remove code that forces text directionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/canvas_win.cc

Issue 10695101: Remove code that forces text directionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove directionality forcing and modes; may be incorrect... Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/canvas_win.cc

diff --git a/ui/gfx/canvas_win.cc b/ui/gfx/canvas_win.cc

index f38dcccb0d2f9f14326dea4fc24776d0167e7655..2c9668e1eff4ea0757cc6593916fb10e55a1d8a3 100644

--- a/ui/gfx/canvas_win.cc

+++ b/ui/gfx/canvas_win.cc

@@ -130,8 +130,10 @@ int ComputeFormatFlags(int flags, const string16& text) {

// Note that if the caller is explicitly requesting displaying the text

// using RTL directionality then we respect that and pass DT_RTLREADING to

// ::DrawText even if the locale is LTR.

- int force_rtl = (flags & gfx::Canvas::FORCE_RTL_DIRECTIONALITY);

- int force_ltr = (flags & gfx::Canvas::FORCE_LTR_DIRECTIONALITY);

+ //

+ // TODO(asvitkine): Deprecate this file...

+ int force_rtl = 0; // (flags & gfx::Canvas::FORCE_RTL_DIRECTIONALITY);

+ int force_ltr = 0; // (flags & gfx::Canvas::FORCE_LTR_DIRECTIONALITY);

bool is_rtl = base::i18n::IsRTL();

bool string_contains_strong_rtl_chars =

base::i18n::StringContainsStrongRTLChars(text);