Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4311)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Issue 10695101: Remove code that forces text directionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove directionality forcing and modes; may be incorrect... Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/canvas.h » ('j') | ui/views/controls/label.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_result_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
index f817a11aa4125f8562a495c193821eb609682850..16604400aa449ccd4c91ba630855f51c98cb0371 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
@@ -440,13 +440,9 @@ int OmniboxResultView::DrawString(
// Draw the runs.
for (Runs::iterator i(runs.begin()); i != runs.end(); ++i) {
- const bool reverse_visible_order = (i->is_rtl != base::i18n::IsRTL());
int flags = gfx::Canvas::NO_ELLIPSIS; // We've already elided.
- if (reverse_visible_order) {
+ if (i->is_rtl != base::i18n::IsRTL())
std::reverse(i->classifications.begin(), i->classifications.end());
- if (i->is_rtl)
- flags |= gfx::Canvas::FORCE_RTL_DIRECTIONALITY;
- }
for (Classifications::const_iterator j(i->classifications.begin());
j != i->classifications.end(); ++j) {
const int left =
« no previous file with comments | « no previous file | ui/gfx/canvas.h » ('j') | ui/views/controls/label.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698