RefCounted types should not have public destructors

base/memory/weak_ptr.h

Index: base/memory/weak_ptr.h
diff --git a/base/memory/weak_ptr.h b/base/memory/weak_ptr.h
index d7c452f1dbb0f796cd6e23f21542a606ee8fe10e..8485c146670d008fad8526f2614503b2368d7a8f 100644
--- a/base/memory/weak_ptr.h
+++ b/base/memory/weak_ptr.h
@@ -162,6 +162,10 @@ class SupportsWeakPtrBase {
     return AsWeakPtrImpl<Derived>(t, *t);
   }
 
+ protected:
+  SupportsWeakPtrBase() {}
+  ~SupportsWeakPtrBase() {}

[Ryan Sleevi, 2012/07/10 22:58:38]

jar:

Unfortunately, for Windows this requires wrapping SupportsWeakPtr<> with a
NON_EXPORTED_BASE if any of the derived types have _EXPORT/_EXPORT_PRIVATE when
building a shared-library build. We already require this for the other
'attribute' types (like base::NonThreadSafe), but since it means this CL will
require touching a lot more code, I removed it for now, and will ping you about
it later.

+
  private:
   // This template function uses type inference to find a Base of Derived
   // which is an instance of SupportsWeakPtr<Base>. We can then safely