Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: webkit/media/buffered_resource_loader.h

Issue 10694098: Use maximum capacity instead of a ratio of capacity for BufferedResourceLoader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/buffered_resource_loader.h
diff --git a/webkit/media/buffered_resource_loader.h b/webkit/media/buffered_resource_loader.h
index da398b1eb2fddfd80b62e4161b2459d60fd529c5..925238c0721285de816b554968c8f621bca7e34f 100644
--- a/webkit/media/buffered_resource_loader.h
+++ b/webkit/media/buffered_resource_loader.h
@@ -31,19 +31,17 @@ const char kHttpScheme[] = "http";
const char kHttpsScheme[] = "https";
const char kDataScheme[] = "data";
-// This class works inside demuxer thread and render thread. It contains a
-// WebURLLoader and does the actual resource loading. This object does
-// buffering internally, it defers the resource loading if buffer is full
-// and un-defers the resource loading if it is under buffered.
+// Wraps a WebURLLoader to maintain an in-memory buffer of downloaded
+// data according to the current defer strategy.
class BufferedResourceLoader : public WebKit::WebURLLoaderClient {
public:
// kNeverDefer - Aggresively buffer; never defer loading while paused.
// kReadThenDefer - Request only enough data to fulfill read requests.
- // kThresholdDefer - Try to keep amount of buffered data at a threshold.
+ // kCapacityDefer - Try to keep amount of buffered data at capacity.
enum DeferStrategy {
kNeverDefer,
kReadThenDefer,
- kThresholdDefer,
+ kCapacityDefer,
};
// Status codes for start/read operations on BufferedResourceLoader.
@@ -179,7 +177,7 @@ class BufferedResourceLoader : public WebKit::WebURLLoaderClient {
bool DidPassCORSAccessCheck() const;
// Sets the defer strategy to the given value unless it seems unwise.
- // Specifically downgrade kNeverDefer to kThresholdDefer if we know the
+ // Specifically downgrade kNeverDefer to kCapacityDefer if we know the
// current response will not be used to satisfy future requests (the cache
// won't help us).
void UpdateDeferStrategy(DeferStrategy strategy);

Powered by Google App Engine
This is Rietveld 408576698