Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 10694093: Remove the force_session cookie option, as it's not used anymore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc
index a139d5d1bde1c85ce5a8130d5bf7f45a00286a40..55917d52a5bab6c618a6751211347d59ac86be9e 100644
--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc
@@ -70,8 +70,8 @@ DictionaryValue* CreateCookieValue(
IsStringUTF8(cookie.Path()) ? cookie.Path() : "");
result->SetBoolean(keys::kSecureKey, cookie.IsSecure());
result->SetBoolean(keys::kHttpOnlyKey, cookie.IsHttpOnly());
- result->SetBoolean(keys::kSessionKey, !cookie.DoesExpire());
- if (cookie.DoesExpire()) {
+ result->SetBoolean(keys::kSessionKey, !cookie.IsPersistent());
+ if (cookie.IsPersistent()) {
result->SetDouble(keys::kExpirationDateKey,
cookie.ExpiryDate().ToDoubleT());
}
@@ -155,7 +155,7 @@ bool MatchFilter::MatchesCookie(
MatchesDomain(cookie.Domain()) &&
MatchesString(keys::kPathKey, cookie.Path()) &&
MatchesBoolean(keys::kSecureKey, cookie.IsSecure()) &&
- MatchesBoolean(keys::kSessionKey, !cookie.DoesExpire());
+ MatchesBoolean(keys::kSessionKey, !cookie.IsPersistent());
}
bool MatchFilter::MatchesString(const char* key, const std::string& value) {
« no previous file with comments | « chrome/browser/automation/automation_util.cc ('k') | chrome/browser/extensions/api/cookies/cookies_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698