Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: chrome/browser/extensions/api/cookies/cookies_unittest.cc

Issue 10694093: Remove the force_session cookie option, as it's not used anymore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Tests common functionality used by the Chrome Extensions Cookies API 5 // Tests common functionality used by the Chrome Extensions Cookies API
6 // implementation. 6 // implementation.
7 7
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) { 106 TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
107 std::string string_value; 107 std::string string_value;
108 bool boolean_value; 108 bool boolean_value;
109 double double_value; 109 double double_value;
110 Value* value; 110 Value* value;
111 111
112 net::CookieMonster::CanonicalCookie cookie1( 112 net::CookieMonster::CanonicalCookie cookie1(
113 GURL(), "ABC", "DEF", "www.foobar.com", "/", 113 GURL(), "ABC", "DEF", "www.foobar.com", "/",
114 std::string(), std::string(), 114 std::string(), std::string(),
115 base::Time(), base::Time(), base::Time(), 115 base::Time(), base::Time(), base::Time(),
116 false, false, false, false); 116 false, false);
117 scoped_ptr<DictionaryValue> cookie_value1( 117 scoped_ptr<DictionaryValue> cookie_value1(
118 cookies_helpers::CreateCookieValue( 118 cookies_helpers::CreateCookieValue(
119 cookie1, "some cookie store")); 119 cookie1, "some cookie store"));
120 EXPECT_TRUE(cookie_value1->GetString(keys::kNameKey, &string_value)); 120 EXPECT_TRUE(cookie_value1->GetString(keys::kNameKey, &string_value));
121 EXPECT_EQ("ABC", string_value); 121 EXPECT_EQ("ABC", string_value);
122 EXPECT_TRUE(cookie_value1->GetString(keys::kValueKey, &string_value)); 122 EXPECT_TRUE(cookie_value1->GetString(keys::kValueKey, &string_value));
123 EXPECT_EQ("DEF", string_value); 123 EXPECT_EQ("DEF", string_value);
124 EXPECT_TRUE(cookie_value1->GetString(keys::kDomainKey, &string_value)); 124 EXPECT_TRUE(cookie_value1->GetString(keys::kDomainKey, &string_value));
125 EXPECT_EQ("www.foobar.com", string_value); 125 EXPECT_EQ("www.foobar.com", string_value);
126 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kHostOnlyKey, &boolean_value)); 126 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kHostOnlyKey, &boolean_value));
127 EXPECT_TRUE(boolean_value); 127 EXPECT_TRUE(boolean_value);
128 EXPECT_TRUE(cookie_value1->GetString(keys::kPathKey, &string_value)); 128 EXPECT_TRUE(cookie_value1->GetString(keys::kPathKey, &string_value));
129 EXPECT_EQ("/", string_value); 129 EXPECT_EQ("/", string_value);
130 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kSecureKey, &boolean_value)); 130 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kSecureKey, &boolean_value));
131 EXPECT_FALSE(boolean_value); 131 EXPECT_FALSE(boolean_value);
132 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kHttpOnlyKey, &boolean_value)); 132 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kHttpOnlyKey, &boolean_value));
133 EXPECT_FALSE(boolean_value); 133 EXPECT_FALSE(boolean_value);
134 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kSessionKey, &boolean_value)); 134 EXPECT_TRUE(cookie_value1->GetBoolean(keys::kSessionKey, &boolean_value));
135 EXPECT_TRUE(boolean_value); 135 EXPECT_TRUE(boolean_value);
136 EXPECT_FALSE( 136 EXPECT_FALSE(
137 cookie_value1->GetDouble(keys::kExpirationDateKey, &double_value)); 137 cookie_value1->GetDouble(keys::kExpirationDateKey, &double_value));
138 EXPECT_TRUE(cookie_value1->GetString(keys::kStoreIdKey, &string_value)); 138 EXPECT_TRUE(cookie_value1->GetString(keys::kStoreIdKey, &string_value));
139 EXPECT_EQ("some cookie store", string_value); 139 EXPECT_EQ("some cookie store", string_value);
140 140
141 net::CookieMonster::CanonicalCookie cookie2( 141 net::CookieMonster::CanonicalCookie cookie2(
142 GURL(), "ABC", "DEF", ".foobar.com", "/", std::string(), std::string(), 142 GURL(), "ABC", "DEF", ".foobar.com", "/", std::string(), std::string(),
143 base::Time(), base::Time::FromDoubleT(10000), base::Time(), 143 base::Time(), base::Time::FromDoubleT(10000), base::Time(),
144 false, false, true, true); 144 false, false);
145 scoped_ptr<DictionaryValue> cookie_value2( 145 scoped_ptr<DictionaryValue> cookie_value2(
146 cookies_helpers::CreateCookieValue( 146 cookies_helpers::CreateCookieValue(
147 cookie2, "some cookie store")); 147 cookie2, "some cookie store"));
148 EXPECT_TRUE(cookie_value2->GetBoolean(keys::kHostOnlyKey, &boolean_value)); 148 EXPECT_TRUE(cookie_value2->GetBoolean(keys::kHostOnlyKey, &boolean_value));
149 EXPECT_FALSE(boolean_value); 149 EXPECT_FALSE(boolean_value);
150 EXPECT_TRUE(cookie_value2->GetBoolean(keys::kSessionKey, &boolean_value)); 150 EXPECT_TRUE(cookie_value2->GetBoolean(keys::kSessionKey, &boolean_value));
151 EXPECT_FALSE(boolean_value); 151 EXPECT_FALSE(boolean_value);
152 EXPECT_TRUE( 152 EXPECT_TRUE(
153 cookie_value2->GetDouble(keys::kExpirationDateKey, &double_value)); 153 cookie_value2->GetDouble(keys::kExpirationDateKey, &double_value));
154 EXPECT_EQ(10000, double_value); 154 EXPECT_EQ(10000, double_value);
155 155
156 TestingProfile profile; 156 TestingProfile profile;
157 ListValue* tab_ids = new ListValue(); 157 ListValue* tab_ids = new ListValue();
158 scoped_ptr<DictionaryValue> cookie_store_value( 158 scoped_ptr<DictionaryValue> cookie_store_value(
159 cookies_helpers::CreateCookieStoreValue(&profile, tab_ids)); 159 cookies_helpers::CreateCookieStoreValue(&profile, tab_ids));
160 EXPECT_TRUE(cookie_store_value->GetString(keys::kIdKey, &string_value)); 160 EXPECT_TRUE(cookie_store_value->GetString(keys::kIdKey, &string_value));
161 EXPECT_EQ("0", string_value); 161 EXPECT_EQ("0", string_value);
162 EXPECT_TRUE(cookie_store_value->Get(keys::kTabIdsKey, &value)); 162 EXPECT_TRUE(cookie_store_value->Get(keys::kTabIdsKey, &value));
163 EXPECT_EQ(tab_ids, value); 163 EXPECT_EQ(tab_ids, value);
164 } 164 }
165 165
166 TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) { 166 TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {
167 net::CookieMonster::CanonicalCookie cookie1( 167 net::CookieMonster::CanonicalCookie cookie1(
168 GURL(), "ABC", "DEF", "www.foobar.com", "/", 168 GURL(), "ABC", "DEF", "www.foobar.com", "/",
169 std::string(), std::string(), 169 std::string(), std::string(),
170 base::Time(), base::Time(), base::Time(), 170 base::Time(), base::Time(), base::Time(),
171 false, false, false, false); 171 false, false);
172 EXPECT_EQ("http://www.foobar.com/", 172 EXPECT_EQ("http://www.foobar.com/",
173 cookies_helpers::GetURLFromCanonicalCookie( 173 cookies_helpers::GetURLFromCanonicalCookie(
174 cookie1).spec()); 174 cookie1).spec());
175 175
176 net::CookieMonster::CanonicalCookie cookie2( 176 net::CookieMonster::CanonicalCookie cookie2(
177 GURL(), "ABC", "DEF", ".helloworld.com", "/", 177 GURL(), "ABC", "DEF", ".helloworld.com", "/",
178 std::string(), std::string(), 178 std::string(), std::string(),
179 base::Time(), base::Time(), base::Time(), 179 base::Time(), base::Time(), base::Time(),
180 true, false, false, false); 180 true, false);
181 EXPECT_EQ("https://helloworld.com/", 181 EXPECT_EQ("https://helloworld.com/",
182 cookies_helpers::GetURLFromCanonicalCookie( 182 cookies_helpers::GetURLFromCanonicalCookie(
183 cookie2).spec()); 183 cookie2).spec());
184 } 184 }
185 185
186 TEST_F(ExtensionCookiesTest, EmptyDictionary) { 186 TEST_F(ExtensionCookiesTest, EmptyDictionary) {
187 scoped_ptr<DictionaryValue> details(new DictionaryValue()); 187 scoped_ptr<DictionaryValue> details(new DictionaryValue());
188 cookies_helpers::MatchFilter filter(details.get()); 188 cookies_helpers::MatchFilter filter(details.get());
189 std::string domain; 189 std::string domain;
190 net::CookieMonster::CanonicalCookie cookie; 190 net::CookieMonster::CanonicalCookie cookie;
(...skipping 12 matching lines...) Expand all
203 { "foo.bar.com", ".bar.com", false } 203 { "foo.bar.com", ".bar.com", false }
204 }; 204 };
205 205
206 scoped_ptr<DictionaryValue> details(new DictionaryValue()); 206 scoped_ptr<DictionaryValue> details(new DictionaryValue());
207 for (size_t i = 0; i < arraysize(tests); ++i) { 207 for (size_t i = 0; i < arraysize(tests); ++i) {
208 details->SetString(keys::kDomainKey, std::string(tests[i].filter)); 208 details->SetString(keys::kDomainKey, std::string(tests[i].filter));
209 cookies_helpers::MatchFilter filter(details.get()); 209 cookies_helpers::MatchFilter filter(details.get());
210 net::CookieMonster::CanonicalCookie cookie(GURL(), "", "", tests[i].domain, 210 net::CookieMonster::CanonicalCookie cookie(GURL(), "", "", tests[i].domain,
211 "", "", "", base::Time(), 211 "", "", "", base::Time(),
212 base::Time(), base::Time(), 212 base::Time(), base::Time(),
213 false, false, false, false); 213 false, false);
214 EXPECT_EQ(tests[i].matches, filter.MatchesCookie(cookie)); 214 EXPECT_EQ(tests[i].matches, filter.MatchesCookie(cookie));
215 } 215 }
216 } 216 }
217 217
218 TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) { 218 TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) {
219 net::CookieMonster::CanonicalCookie cookie(GURL(), "", 219 net::CookieMonster::CanonicalCookie cookie(GURL(), "",
220 "011Q255bNX_1!yd\203e+", 220 "011Q255bNX_1!yd\203e+",
221 "test.com", 221 "test.com",
222 "/path\203", "", "", base::Time(), 222 "/path\203", "", "", base::Time(),
223 base::Time(), base::Time(), 223 base::Time(), base::Time(),
224 false, false, false, false); 224 false, false);
225 scoped_ptr<DictionaryValue> cookie_value( 225 scoped_ptr<DictionaryValue> cookie_value(
226 cookies_helpers::CreateCookieValue( 226 cookies_helpers::CreateCookieValue(
227 cookie, "some cookie store")); 227 cookie, "some cookie store"));
228 std::string string_value; 228 std::string string_value;
229 EXPECT_TRUE(cookie_value->GetString(keys::kValueKey, &string_value)); 229 EXPECT_TRUE(cookie_value->GetString(keys::kValueKey, &string_value));
230 EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD" "e+"), string_value); 230 EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD" "e+"), string_value);
231 EXPECT_TRUE(cookie_value->GetString(keys::kPathKey, &string_value)); 231 EXPECT_TRUE(cookie_value->GetString(keys::kPathKey, &string_value));
232 EXPECT_EQ(std::string(""), string_value); 232 EXPECT_EQ(std::string(""), string_value);
233 } 233 }
234 234
235 } // namespace extensions 235 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/net/sqlite_persistent_cookie_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698