Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: chrome/browser/extensions/permissions_updater.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/permissions_updater.cc
diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc
index e56fbba23a768e5fffca50c36dfc209b29ec88ef..aa06d0ac0dacc68b7c3dc1e898b466308cb49fa5 100644
--- a/chrome/browser/extensions/permissions_updater.cc
+++ b/chrome/browser/extensions/permissions_updater.cc
@@ -117,14 +117,12 @@ void PermissionsUpdater::DispatchEvent(
if (!profile_ || !profile_->GetExtensionEventRouter())
return;
- ListValue value;
+ scoped_ptr<ListValue> value(new ListValue());
scoped_ptr<api::permissions::Permissions> permissions =
PackPermissionSet(changed_permissions);
- value.Append(permissions->ToValue().release());
- std::string json_value;
- base::JSONWriter::Write(&value, &json_value);
+ value->Append(permissions->ToValue().release());
profile_->GetExtensionEventRouter()->DispatchEventToExtension(
- extension_id, event_name, json_value, profile_, GURL());
+ extension_id, event_name, value.Pass(), profile_, GURL());
}
void PermissionsUpdater::NotifyPermissionsUpdated(
« no previous file with comments | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | chrome/browser/extensions/settings/settings_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698