chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/browser_event_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 3976343d1fe1ad0409f7b65c89e5bf31989b5215..e330fe0db12c1e150ffe4620b75bc30b3d43a501 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -587,18 +587,11 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {

continue;

}

- std::string event_arg_string;

- ASSERT_TRUE(args.GetString(1, &event_arg_string));

- scoped_ptr<Value> event_arg_value(

- JSONStringValueSerializer(event_arg_string).Deserialize(NULL, NULL));

- ASSERT_TRUE(event_arg_value.get() &&

- event_arg_value->IsType(Value::TYPE_LIST));

+ ListValue* event_arg = NULL;

+ ASSERT_TRUE(args.GetList(1, &event_arg));

DictionaryValue* event_arg_dict = NULL;

- ASSERT_TRUE(

- static_cast<ListValue*>(event_arg_value.get())->GetDictionary(

- 0, &event_arg_dict));

+ ASSERT_TRUE(event_arg->GetDictionary(0, &event_arg_dict));

ListValue* request_headers = NULL;

ASSERT_TRUE(event_arg_dict->GetList(keys::kRequestHeadersKey,

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/browser_event_router.h » ('j') | no next file with comments »