chrome/browser/extensions/api/terminal/terminal_private_api.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc

diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc

index 1d0d718338ef20ef9aa21628572774b68db0877b..e2de983268eaad70e94f2ca72b6e754ce2e087e9 100644

--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc

+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc

@@ -50,18 +50,15 @@ void NotifyProcessOutput(Profile* profile,

return;

}

- base::ListValue args;

- args.Append(new base::FundamentalValue(pid));

- args.Append(new base::StringValue(output_type));

- args.Append(new base::StringValue(output));

- std::string args_json;

- base::JSONWriter::Write(&args, &args_json);

+ scoped_ptr<base::ListValue> args(new base::ListValue());

+ args->Append(new base::FundamentalValue(pid));

+ args->Append(new base::StringValue(output_type));

+ args->Append(new base::StringValue(output));

if (profile && profile->GetExtensionEventRouter()) {

profile->GetExtensionEventRouter()->DispatchEventToExtension(

extension_id, extensions::event_names::kOnTerminalProcessOutput,

- args_json, NULL, GURL());

+ args.Pass(), NULL, GURL());

}