chrome/browser/extensions/api/managed_mode/managed_mode_api.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/managed_mode/managed_mode_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/managed_mode/managed_mode_api.cc

diff --git a/chrome/browser/extensions/api/managed_mode/managed_mode_api.cc b/chrome/browser/extensions/api/managed_mode/managed_mode_api.cc

index dc50e136aa4df862ce5010d944f88652ceba3d8c..b4d95b48fea3b5b092a191e5301e782f8d042a20 100644

--- a/chrome/browser/extensions/api/managed_mode/managed_mode_api.cc

+++ b/chrome/browser/extensions/api/managed_mode/managed_mode_api.cc

@@ -60,15 +60,14 @@ void ExtensionManagedModeEventRouter::Observe(

*content::Details<std::string>(details).ptr();

DCHECK_EQ(std::string(prefs::kInManagedMode), pref_name);

- ListValue args;

DictionaryValue* dict = new DictionaryValue();

- args.Append(dict);

dict->SetBoolean(extension_preference_api_constants::kValue,

g_browser_process->local_state()->GetBoolean(prefs::kInManagedMode));

- std::string json_args;

- base::JSONWriter::Write(&args, &json_args);

+ scoped_ptr<ListValue> args(new ListValue());

+ args->Set(0, dict);

extensions::EventRouter* event_router = profile_->GetExtensionEventRouter();

- event_router->DispatchEventToRenderers(kChangeEventName, json_args, NULL,

+ event_router->DispatchEventToRenderers(kChangeEventName, args.Pass(), NULL,

GURL(),

extensions::EventFilteringInfo());

}