chrome/browser/bookmarks/bookmark_extension_api.h - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_extension_api.h

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/accessibility/accessibility_extension_api.cc ('k') | chrome/browser/bookmarks/bookmark_extension_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_extension_api.h

diff --git a/chrome/browser/bookmarks/bookmark_extension_api.h b/chrome/browser/bookmarks/bookmark_extension_api.h

index fd0ff0f9c0945338e01db91a532aea00c346b1e0..5a3f54ea1bd9714b1428f4d2381d60224fd4cceb 100644

--- a/chrome/browser/bookmarks/bookmark_extension_api.h

+++ b/chrome/browser/bookmarks/bookmark_extension_api.h

@@ -60,7 +60,7 @@ class BookmarkExtensionEventRouter : public BookmarkModelObserver {

// Helper to actually dispatch an event to extension listeners.

void DispatchEvent(Profile* profile,

const char* event_name,

- const std::string& json_args);

+ scoped_ptr<base::ListValue> event_args);

BookmarkModel* model_;

« no previous file with comments | « chrome/browser/accessibility/accessibility_extension_api.cc ('k') | chrome/browser/bookmarks/bookmark_extension_api.cc » ('j') | no next file with comments »