chrome/browser/history/history_extension_api.h - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_extension_api.h

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/system/system_api.cc ('K') | « chrome/browser/extensions/system/system_api.cc ('k') | chrome/browser/history/history_extension_api.cc » ('j') | chrome/browser/speech/speech_input_extension_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_extension_api.h

diff --git a/chrome/browser/history/history_extension_api.h b/chrome/browser/history/history_extension_api.h

index bd5b2f2c5bc90d0ef861609ad39c2833d20a5b15..e2443c0feba31bede9199f8d61f1168258a3843a 100644

--- a/chrome/browser/history/history_extension_api.h

+++ b/chrome/browser/history/history_extension_api.h

@@ -14,6 +14,10 @@

#include "chrome/browser/history/history_notifications.h"

#include "content/public/browser/notification_registrar.h"

+namespace base {

+class ListValue;

// Observes History service and routes the notifications as events to the

// extension system.

class HistoryExtensionEventRouter : public content::NotificationObserver {

@@ -37,7 +41,7 @@ class HistoryExtensionEventRouter : public content::NotificationObserver {

void DispatchEvent(Profile* profile,

const char* event_name,

- const std::string& json_args);

+ base::ListValue* event_args);

// Used for tracking registrations to history service notifications.

content::NotificationRegistrar registrar_;