chrome/browser/extensions/permissions_updater.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/permissions_updater.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | chrome/browser/extensions/settings/settings_frontend.cc » ('j') | chrome/browser/extensions/system/system_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permissions_updater.cc

diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc

index d2940ddf291a05ca1dd7492f152e17c0dab90399..cfb64ff556179a87e217bed443e6615cda7a0fbd 100644

--- a/chrome/browser/extensions/permissions_updater.cc

+++ b/chrome/browser/extensions/permissions_updater.cc

@@ -137,14 +137,12 @@ void PermissionsUpdater::DispatchEvent(

if (!profile_ || !profile_->GetExtensionEventRouter())

return;

- ListValue value;

+ ListValue* value = new ListValue();

scoped_ptr<api::permissions::Permissions> permissions =

PackPermissionSet(changed_permissions);

- value.Append(permissions->ToValue().release());

- std::string json_value;

- base::JSONWriter::Write(&value, &json_value);

+ value->Append(permissions->ToValue().release());

profile_->GetExtensionEventRouter()->DispatchEventToExtension(

- extension_id, event_name, json_value, profile_, GURL());

+ extension_id, event_name, value, profile_, GURL());

}

void PermissionsUpdater::NotifyPermissionsUpdated(