chrome/browser/extensions/extension_idle_api.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_idle_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_event_router.cc ('K') | « chrome/browser/extensions/extension_event_router_forwarder_unittest.cc ('k') | chrome/browser/extensions/extension_input_ime_api.cc » ('j') | chrome/browser/extensions/extension_processes_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_idle_api.cc

diff --git a/chrome/browser/extensions/extension_idle_api.cc b/chrome/browser/extensions/extension_idle_api.cc

index 87ce7641ce56291ff96a6dba86677042d0e0c230..845e1b9334d9172d441f8d3aacbf75a06e5b4abb 100644

--- a/chrome/browser/extensions/extension_idle_api.cc

+++ b/chrome/browser/extensions/extension_idle_api.cc

@@ -139,13 +139,11 @@ int CheckThresholdBounds(int timeout) {

void ExtensionIdleEventRouter::OnIdleStateChange(Profile* profile,

IdleState state) {

// Prepare the single argument of the current state.

- ListValue args;

- args.Append(CreateIdleValue(state));

- std::string json_args;

- base::JSONWriter::Write(&args, &json_args);

+ ListValue* args = new ListValue();

+ args->Append(CreateIdleValue(state));

profile->GetExtensionEventRouter()->DispatchEventToRenderers(

- keys::kOnStateChanged, json_args, profile, GURL(), EventFilteringInfo());

+ keys::kOnStateChanged, args, profile, GURL(), EventFilteringInfo());

}

bool ExtensionIdleQueryStateFunction::RunImpl() {