chrome/browser/extensions/extension_browser_event_router.h - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_event_router.h

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('K') | « chrome/browser/extensions/event_listener_map_unittest.cc ('k') | chrome/browser/extensions/extension_browser_event_router.cc » ('j') | chrome/browser/extensions/extension_browser_event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browser_event_router.h

diff --git a/chrome/browser/extensions/extension_browser_event_router.h b/chrome/browser/extensions/extension_browser_event_router.h

index 4cb53918459556a54e725aac3e35f502d329234d..7cb26f749dbae229e591d7600f836975f648ac5f 100644

--- a/chrome/browser/extensions/extension_browser_event_router.h

+++ b/chrome/browser/extensions/extension_browser_event_router.h

@@ -126,17 +126,17 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,

// so we avoid duplication by dropping events destined for other profiles.

void DispatchEvent(Profile* profile,

const char* event_name,

- const std::string& json_args);

+ base::ListValue* arguments);

miket_OOO 2012/07/10 22:33:19 There should be some documentation here about owne

void DispatchEventToExtension(Profile* profile,

const std::string& extension_id,

const char* event_name,

- const std::string& json_args);

+ base::ListValue* event_args);

void DispatchEventsAcrossIncognito(Profile* profile,

const char* event_name,

- const std::string& json_args,

- const std::string& cross_incognito_args);

+ base::ListValue* event_args,

+ base::ListValue* cross_incognito_args);

void DispatchEventWithTab(Profile* profile,

const std::string& extension_id,