Refactor extension event distribution to use Values instead of JSON strings.

chrome/renderer/resources/extensions/event.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
   var DCHECK = requireNative('logging').DCHECK;
   var eventBindingsNatives = requireNative('event_bindings');
   var AttachEvent = eventBindingsNatives.AttachEvent;
   var DetachEvent = eventBindingsNatives.DetachEvent;
   var AttachFilteredEvent = eventBindingsNatives.AttachFilteredEvent;
   var DetachFilteredEvent = eventBindingsNatives.DetachFilteredEvent;
@@ skipping 192 matching lines @@
         }
       };
     } else {
       this.validateEventArgs_ = function() {}
     }
   };
 
   chromeHidden.Event = {};
 
   // callback is a function(args, dispatch). args are the args we receive from
-  // dispatchJSON(), and dispatch is a function(args) that dispatches args to
+  // dispatchEvent(), and dispatch is a function(args) that dispatches args to
   // its listeners.
   chromeHidden.Event.registerArgumentMassager = function(name, callback) {
     if (eventArgumentMassagers[name])
       throw new Error("Massager already registered for event: " + name);
     eventArgumentMassagers[name] = callback;
   };
 
-  // Dispatches a named event with the given JSON array, which is deserialized
-  // before dispatch. The JSON array is the list of arguments that will be
-  // sent with the event callback.
-  chromeHidden.Event.dispatchJSON = function(name, args, filteringInfo) {
+  // Dispatches a named event with the given argument array. The args array is
+  // the list of arguments that will be sent to the event callback.
+  chromeHidden.Event.dispatchEvent = function(name, args, filteringInfo) {
     var listenerIDs = null;
 
     if (filteringInfo)
       listenerIDs = MatchAgainstEventFilter(name, filteringInfo);
 
     var event = attachedNamedEvents[name];
     if (!event)
       return;
 
-    // TODO(asargent): This is an antiquity. Until all callers of
-    // dispatchJSON use actual values, this must remain here to catch the
-    // cases where a caller has hard-coded a JSON string to pass in.
-    if (typeof(args) == "string")
-      args = chromeHidden.JSON.parse(args);
-
     var dispatchArgs = function(args) {
       result = event.dispatch_(args, listenerIDs);
       if (result)
         DCHECK(!result.validationErrors, result.validationErrors);
     };
 
     if (eventArgumentMassagers[name])
       eventArgumentMassagers[name](args, dispatchArgs);
     else
       dispatchArgs(args);
@@ skipping 226 matching lines @@
       if (event)
         event.detach_();
     }
   };
 
   chromeHidden.dispatchError = function(msg) {
     console.error(msg);
   };
 
   exports.Event = chrome.Event;