Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/extensions/api/proxy/proxy_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of the Chrome Extensions Proxy Settings API.
 
 #include "chrome/browser/extensions/api/proxy/proxy_api.h"
 
 #include "base/json/json_writer.h"
 #include "base/stringprintf.h"
@@ skipping 19 matching lines @@
 ProxyEventRouter::ProxyEventRouter() {
 }
 
 ProxyEventRouter::~ProxyEventRouter() {
 }
 
 void ProxyEventRouter::OnProxyError(
     EventRouterForwarder* event_router,
     void* profile,
     int error_code) {
-  ListValue args;
+  scoped_ptr<ListValue> args(new ListValue());
   DictionaryValue* dict = new DictionaryValue();
   dict->SetBoolean(keys::kProxyEventFatal, true);
   dict->SetString(keys::kProxyEventError, net::ErrorToString(error_code));
   dict->SetString(keys::kProxyEventDetails, "");
-  args.Append(dict);
-
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
+  args->Append(dict);
 
   if (profile) {
     event_router->DispatchEventToRenderers(
-        keys::kProxyEventOnProxyError, json_args, profile, true, GURL());
+        keys::kProxyEventOnProxyError, args.Pass(), profile, true, GURL());
   } else {
     event_router->BroadcastEventToRenderers(
-        keys::kProxyEventOnProxyError, json_args, GURL());
+        keys::kProxyEventOnProxyError, args.Pass(), GURL());
   }
 }
 
 void ProxyEventRouter::OnPACScriptError(
     EventRouterForwarder* event_router,
     void* profile,
     int line_number,
     const string16& error) {
-  ListValue args;
+  scoped_ptr<ListValue> args(new ListValue());
   DictionaryValue* dict = new DictionaryValue();
   dict->SetBoolean(keys::kProxyEventFatal, false);
   dict->SetString(keys::kProxyEventError,
                   net::ErrorToString(net::ERR_PAC_SCRIPT_FAILED));
   std::string error_msg;
   if (line_number != -1) {
     base::SStringPrintf(
         &error_msg, "line: %d: %s", line_number, UTF16ToUTF8(error).c_str());
   } else {
     error_msg = UTF16ToUTF8(error);
   }
   dict->SetString(keys::kProxyEventDetails, error_msg);
-  args.Append(dict);
-
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
+  args->Append(dict);
 
   if (profile) {
     event_router->DispatchEventToRenderers(
-        keys::kProxyEventOnProxyError, json_args, profile, true, GURL());
+        keys::kProxyEventOnProxyError, args.Pass(), profile, true, GURL());
   } else {
     event_router->BroadcastEventToRenderers(
-        keys::kProxyEventOnProxyError, json_args, GURL());
+        keys::kProxyEventOnProxyError, args.Pass(), GURL());
   }
 }
 
 ProxyPrefTransformer::ProxyPrefTransformer() {
 }
 
 ProxyPrefTransformer::~ProxyPrefTransformer() {
 }
 
 Value* ProxyPrefTransformer::ExtensionToBrowserPref(const Value* extension_pref,
@@ skipping 81 matching lines @@
       extension_pref->Set(keys::kProxyConfigRules, proxy_rules_dict);
       break;
     }
     case ProxyPrefs::kModeCount:
       NOTREACHED();
   }
   return extension_pref.release();
 }
 
 }  // namespace extensions