Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/extensions/api/omnibox/omnibox_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
 
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
@@ skipping 33 matching lines @@
 const char kSuggestionDescriptionStylesRaw[] = "descriptionStylesRaw";
 const char kDescriptionStylesType[] = "type";
 const char kDescriptionStylesOffset[] = "offset";
 const char kDescriptionStylesLength[] = "length";
 
 }  // namespace
 
 // static
 void ExtensionOmniboxEventRouter::OnInputStarted(
     Profile* profile, const std::string& extension_id) {
-  profile->GetExtensionEventRouter()->DispatchEventToExtension(
-      extension_id, events::kOnInputStarted, "[]", profile, GURL());
+  scoped_ptr<ListValue> event_args(new ListValue());
+  profile->GetExtensionEventRouter()->DispatchEventToExtension(extension_id,
+      events::kOnInputStarted, event_args.Pass(), profile, GURL());
 }
 
 // static
 bool ExtensionOmniboxEventRouter::OnInputChanged(
     Profile* profile, const std::string& extension_id,
     const std::string& input, int suggest_id) {
   if (!profile->GetExtensionEventRouter()->ExtensionHasEventListener(
         extension_id, events::kOnInputChanged))
     return false;
 
-  ListValue args;
-  args.Set(0, Value::CreateStringValue(input));
-  args.Set(1, Value::CreateIntegerValue(suggest_id));
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
+  scoped_ptr<ListValue> args(new ListValue());
+  args->Set(0, Value::CreateStringValue(input));
+  args->Set(1, Value::CreateIntegerValue(suggest_id));
 
   profile->GetExtensionEventRouter()->DispatchEventToExtension(
-      extension_id, events::kOnInputChanged, json_args, profile, GURL());
+      extension_id, events::kOnInputChanged, args.Pass(), profile, GURL());
   return true;
 }
 
 // static
 void ExtensionOmniboxEventRouter::OnInputEntered(
     TabContents* tab_contents,
     const std::string& extension_id,
     const std::string& input) {
   Profile* profile = tab_contents->profile();
 
   const Extension* extension =
       ExtensionSystem::Get(profile)->extension_service()->extensions()->
           GetByID(extension_id);
   CHECK(extension);
   tab_contents->extension_tab_helper()->active_tab_permission_manager()->
       GrantIfRequested(extension);
 
-  ListValue args;
-  args.Set(0, Value::CreateStringValue(input));
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
+  scoped_ptr<ListValue> args(new ListValue());
+  args->Set(0, Value::CreateStringValue(input));
 
   profile->GetExtensionEventRouter()->DispatchEventToExtension(
-      extension_id, events::kOnInputEntered, json_args, profile, GURL());
+      extension_id, events::kOnInputEntered, args.Pass(), profile, GURL());
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_OMNIBOX_INPUT_ENTERED,
       content::Source<Profile>(profile),
       content::NotificationService::NoDetails());
 }
 
 // static
 void ExtensionOmniboxEventRouter::OnInputCancelled(
     Profile* profile, const std::string& extension_id) {
+  scoped_ptr<ListValue> args(new ListValue());
   profile->GetExtensionEventRouter()->DispatchEventToExtension(
-      extension_id, events::kOnInputCancelled, "[]", profile, GURL());
+      extension_id, events::kOnInputCancelled, args.Pass(), profile, GURL());
 }
 
 bool OmniboxSendSuggestionsFunction::RunImpl() {
   ExtensionOmniboxSuggestions suggestions;
   ListValue* suggestions_value;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &suggestions.request_id));
   EXTENSION_FUNCTION_VALIDATE(args_->GetList(1, &suggestions_value));
 
   suggestions.suggestions.resize(suggestions_value->GetSize());
   for (size_t i = 0; i < suggestions_value->GetSize(); ++i) {
@@ skipping 183 matching lines @@
     for (size_t i = 0; i < description_styles.size(); ++i) {
       if (description_styles[i].offset > placeholder)
         description_styles[i].offset += replacement.length() - 2;
     }
   }
 
   match->contents.assign(description);
 }
 
 }  // namespace extensions