Refactor extension event distribution to use Values instead of JSON strings.

chrome/renderer/resources/extensions/event.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
   var eventBindingsNatives = requireNative('event_bindings');
   var AttachEvent = eventBindingsNatives.AttachEvent;
   var DetachEvent = eventBindingsNatives.DetachEvent;
   var AttachFilteredEvent = eventBindingsNatives.AttachFilteredEvent;
   var DetachFilteredEvent = eventBindingsNatives.DetachFilteredEvent;
   var MatchAgainstEventFilter = eventBindingsNatives.MatchAgainstEventFilter;
@@ skipping 196 matching lines @@
   };
 
   chromeHidden.Event = {};
 
   chromeHidden.Event.registerArgumentMassager = function(name, fn) {
     if (eventArgumentMassagers[name])
       throw new Error("Massager already registered for event: " + name);
     eventArgumentMassagers[name] = fn;
   };
 
-  // Dispatches a named event with the given JSON array, which is deserialized
-  // before dispatch. The JSON array is the list of arguments that will be
-  // sent with the event callback.
-  chromeHidden.Event.dispatchJSON = function(name, args, filteringInfo) {
+  // Dispatches a named event with the given argument array. The args array is
+  // the list of arguments that will be sent to the event callback.
+  chromeHidden.Event.dispatch = function(name, args) {
     var listenerIDs = null;
 
     if (filteringInfo) {
       listenerIDs = MatchAgainstEventFilter(name, filteringInfo);
     }
     if (attachedNamedEvents[name]) {
       if (args) {
-        // TODO(asargent): This is an antiquity. Until all callers of
-        // dispatchJSON use actual values, this must remain here to catch the
-        // cases where a caller has hard-coded a JSON string to pass in.
-        if (typeof(args) == "string") {
-          args = chromeHidden.JSON.parse(args);
-        }
         if (eventArgumentMassagers[name])
           eventArgumentMassagers[name](args);
       }
 
       var event = attachedNamedEvents[name];
       var result;
       // TODO(koz): We have to do this differently for unfiltered events (which
       // have listenerIDs = null) because some bindings write over
       // event.dispatch (eg: experimental.app.custom_bindings.js) and so expect
       // events to go through it. These places need to be fixed so that they
@@ skipping 229 matching lines @@
       if (event)
         event.detach_();
     }
   };
 
   chromeHidden.dispatchError = function(msg) {
     console.error(msg);
   };
 
   exports.Event = chrome.Event;