Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/history/history_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/history_extension_api.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/json/json_writer.h"
@@ skipping 111 matching lines @@
           content::Details<const history::URLsDeletedDetails>(details).ptr());
       break;
     default:
       NOTREACHED();
   }
 }
 
 void HistoryExtensionEventRouter::HistoryUrlVisited(
     Profile* profile,
     const history::URLVisitedDetails* details) {
-  ListValue args;
+  ListValue* args = new ListValue();
   DictionaryValue* dict = new DictionaryValue();
   GetHistoryItemDictionary(details->row, dict);
-  args.Append(dict);
+  args->Append(dict);
 
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
-  DispatchEvent(profile, kOnVisited, json_args);
+  DispatchEvent(profile, kOnVisited, args);
 }
 
 void HistoryExtensionEventRouter::HistoryUrlsRemoved(
     Profile* profile,
     const history::URLsDeletedDetails* details) {
-  ListValue args;
+  ListValue* args = new ListValue();
   DictionaryValue* dict = new DictionaryValue();
   dict->SetBoolean(kAllHistoryKey, details->all_history);
   ListValue* urls = new ListValue();
   for (history::URLRows::const_iterator iterator = details->rows.begin();
       iterator != details->rows.end(); ++iterator) {
     urls->Append(new StringValue(iterator->url().spec()));
   }
   dict->Set(kUrlsKey, urls);
-  args.Append(dict);
+  args->Append(dict);
 
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
-  DispatchEvent(profile, kOnVisitRemoved, json_args);
+  DispatchEvent(profile, kOnVisitRemoved, args);
 }
 
 void HistoryExtensionEventRouter::DispatchEvent(Profile* profile,
                                                 const char* event_name,
-                                                const std::string& json_args) {
+                                                ListValue* event_args) {
   if (profile && profile->GetExtensionEventRouter()) {
     profile->GetExtensionEventRouter()->DispatchEventToRenderers(
-        event_name, json_args, profile, GURL(),
+        event_name, event_args, profile, GURL(),
         extensions::EventFilteringInfo());
   }
 }
 
 void HistoryFunction::Run() {
   if (!RunImpl()) {
     SendResponse(false);
   }
 }
 
@@ skipping 229 matching lines @@
       &cancelable_consumer_,
       base::Bind(&DeleteAllHistoryFunction::DeleteComplete,
                  base::Unretained(this)));
 
   return true;
 }
 
 void DeleteAllHistoryFunction::DeleteComplete() {
   SendAsyncResponse();
 }