Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/extensions/extension_event_router_forwarder_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_event_router_forwarder.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/system_monitor/system_monitor.h"
 #include "base/test/thread_test_helper.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 namespace {
 
 const char kEventName[] = "event_name";
-const char kEventArgs[] = "event_args";
 const char kExt[] = "extension";
 
 class MockExtensionEventRouterForwarder : public ExtensionEventRouterForwarder {
  public:
   MOCK_METHOD6(CallExtensionEventRouter,
-      void(Profile*, const std::string&, const std::string&, const std::string&,
+      void(Profile*, const std::string&, const std::string&, base::ListValue*,
            Profile*, const GURL&));
 
  protected:
   virtual ~MockExtensionEventRouterForwarder() {}
 };
 
 }  // namespace
 
 class ExtensionEventRouterForwarderTest : public testing::Test {
  protected:
@@ skipping 34 matching lines @@
   TestingProfile* profile1_;
   TestingProfile* profile2_;
 };
 
 TEST_F(ExtensionEventRouterForwarderTest, BroadcastRendererUI) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, profile1_, url));
+          profile1_, "", kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile2_, "", kEventName, kEventArgs, profile2_, url));
-  event_router->BroadcastEventToRenderers(kEventName, kEventArgs, url);
+          profile2_, "", kEventName, NULL, profile2_, url));
+  event_router->BroadcastEventToRenderers(kEventName, NULL, url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest, BroadcastRendererUIIncognito) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   using ::testing::_;
   GURL url;
   Profile* incognito = CreateIncognitoProfile(profile1_);
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, profile1_, url));
+          profile1_, "", kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(incognito, _, _, _, _, _)).Times(0);
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile2_, "", kEventName, kEventArgs, profile2_, url));
-  event_router->BroadcastEventToRenderers(kEventName, kEventArgs, url);
+          profile2_, "", kEventName, NULL, profile2_, url));
+  event_router->BroadcastEventToRenderers(kEventName, NULL, url);
 }
 
 // This is the canonical test for passing control flow from the IO thread
 // to the UI thread. Repeating this for all public functions of
 // ExtensionEventRouterForwarder would not increase coverage.
 TEST_F(ExtensionEventRouterForwarderTest, BroadcastRendererIO) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, profile1_, url));
+          profile1_, "", kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile2_, "", kEventName, kEventArgs, profile2_, url));
+          profile2_, "", kEventName, NULL, profile2_, url));
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
       base::Bind(
           &MockExtensionEventRouterForwarder::BroadcastEventToRenderers,
-          event_router.get(),
-          std::string(kEventName), std::string(kEventArgs), url));
+          event_router.get(), std::string(kEventName),
+          static_cast<base::ListValue*>(NULL), url));
 
   // Wait for IO thread's message loop to be processed
   scoped_refptr<base::ThreadTestHelper> helper(
       new base::ThreadTestHelper(
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
   ASSERT_TRUE(helper->Run());
 
   MessageLoop::current()->RunAllPending();
 }
 
 TEST_F(ExtensionEventRouterForwarderTest, UnicastRendererUIRestricted) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, profile1_, url));
+          profile1_, "", kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToRenderers(kEventName, kEventArgs,
-                                         profile1_, true, url);
+  event_router->DispatchEventToRenderers(kEventName, NULL, profile1_, true,
+                                         url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest,
        UnicastRendererUIRestrictedIncognito1) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   Profile* incognito = CreateIncognitoProfile(profile1_);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, profile1_, url));
+          profile1_, "", kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(incognito, _, _, _, _, _)).Times(0);
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToRenderers(kEventName, kEventArgs,
+  event_router->DispatchEventToRenderers(kEventName, NULL,
                                          profile1_, true, url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest,
        UnicastRendererUIRestrictedIncognito2) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   Profile* incognito = CreateIncognitoProfile(profile1_);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile1_, _, _, _, _, _)).Times(0);
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          incognito, "", kEventName, kEventArgs, incognito, url));
+          incognito, "", kEventName, NULL, incognito, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToRenderers(kEventName, kEventArgs,
+  event_router->DispatchEventToRenderers(kEventName, NULL,
                                          incognito, true, url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest, UnicastRendererUIUnrestricted) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
-      CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, NULL, url));
+      CallExtensionEventRouter(profile1_, "", kEventName, NULL, NULL, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToRenderers(kEventName, kEventArgs,
+  event_router->DispatchEventToRenderers(kEventName, NULL,
                                          profile1_, false, url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest,
        UnicastRendererUIUnrestrictedIncognito) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   Profile* incognito = CreateIncognitoProfile(profile1_);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
-      CallExtensionEventRouter(
-          profile1_, "", kEventName, kEventArgs, NULL, url));
+      CallExtensionEventRouter(profile1_, "", kEventName, NULL, NULL, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(incognito, _, _, _, _, _)).Times(0);
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToRenderers(kEventName, kEventArgs,
-                                         profile1_, false, url);
+  event_router->DispatchEventToRenderers(kEventName, NULL, profile1_, false,
+                                         url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest, BroadcastExtensionUI) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, kExt, kEventName, kEventArgs, profile1_, url));
+          profile1_, kExt, kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile2_, kExt, kEventName, kEventArgs, profile2_, url));
-  event_router->BroadcastEventToExtension(kExt, kEventName, kEventArgs, url);
+          profile2_, kExt, kEventName, NULL, profile2_, url));
+  event_router->BroadcastEventToExtension(kExt, kEventName, NULL, url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest, UnicastExtensionUIRestricted) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, kExt, kEventName, kEventArgs, profile1_, url));
+          profile1_, kExt, kEventName, NULL, profile1_, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToExtension(kExt, kEventName, kEventArgs,
+  event_router->DispatchEventToExtension(kExt, kEventName, NULL,
                                          profile1_, true, url);
 }
 
 TEST_F(ExtensionEventRouterForwarderTest, UnicastExtensionUIUnrestricted) {
   scoped_refptr<MockExtensionEventRouterForwarder> event_router(
       new MockExtensionEventRouterForwarder);
   using ::testing::_;
   GURL url;
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(
-          profile1_, kExt, kEventName, kEventArgs, NULL, url));
+          profile1_, kExt, kEventName, NULL, NULL, url));
   EXPECT_CALL(*event_router,
       CallExtensionEventRouter(profile2_, _, _, _, _, _)).Times(0);
-  event_router->DispatchEventToExtension(kExt, kEventName, kEventArgs,
+  event_router->DispatchEventToExtension(kExt, kEventName, NULL,
                                          profile1_, false, url);
 }