Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/extensions/extension_debugger_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Debugger API.
 
 #include "chrome/browser/extensions/extension_debugger_api.h"
 
 #include <map>
 #include <set>
@@ skipping 230 matching lines @@
 
   std::string json_args;
   base::JSONWriter::Write(&protocol_request, &json_args);
   DevToolsManager::GetInstance()->DispatchOnInspectorBackend(this, json_args);
 }
 
 void ExtensionDevToolsClientHost::SendDetachedEvent() {
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   if (profile != NULL && profile->GetExtensionEventRouter()) {
-    ListValue args;
-    args.Append(CreateDebuggeeId(tab_id_));
-
-    std::string json_args;
-    base::JSONWriter::Write(&args, &json_args);
+    ListValue* args = new ListValue();
+    args->Append(CreateDebuggeeId(tab_id_));
 
     profile->GetExtensionEventRouter()->DispatchEventToExtension(
-        extension_id_, keys::kOnDetach, json_args, profile, GURL());
+        extension_id_, keys::kOnDetach, args, profile, GURL());
   }
 }
 
 void ExtensionDevToolsClientHost::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   if (type == chrome::NOTIFICATION_EXTENSION_UNLOADED) {
     std::string id =
         content::Details<extensions::UnloadedExtensionInfo>(details)->
@@ skipping 22 matching lines @@
   if (!result->IsType(Value::TYPE_DICTIONARY))
     return;
   DictionaryValue* dictionary = static_cast<DictionaryValue*>(result.get());
 
   int id;
   if (!dictionary->GetInteger("id", &id)) {
     std::string method_name;
     if (!dictionary->GetString("method", &method_name))
       return;
 
-    ListValue args;
-    args.Append(CreateDebuggeeId(tab_id_));
-    args.Append(Value::CreateStringValue(method_name));
+    ListValue* args = new ListValue();
+    args->Append(CreateDebuggeeId(tab_id_));
+    args->Append(Value::CreateStringValue(method_name));
     Value* params_value;
     if (dictionary->Get("params", &params_value))
-      args.Append(params_value->DeepCopy());
-
-    std::string json_args;
-    base::JSONWriter::Write(&args, &json_args);
+      args->Append(params_value->DeepCopy());
 
     profile->GetExtensionEventRouter()->DispatchEventToExtension(
-        extension_id_, keys::kOnEvent, json_args, profile, GURL());
+        extension_id_, keys::kOnEvent, args, profile, GURL());
   } else {
     SendCommandDebuggerFunction* function = pending_requests_[id];
     if (!function)
       return;
 
     function->SendResponseBody(dictionary);
     pending_requests_.erase(id);
   }
 }
 
@@ skipping 160 matching lines @@
     return;
   }
 
   Value* result_body;
   if (dictionary->Get("result", &result_body))
     result_.reset(result_body->DeepCopy());
   else
     result_.reset(new DictionaryValue());
   SendResponse(true);
 }