Add read-only access to POST data for webRequest's onBeforeRequest

chrome/common/extensions/docs/extensions/webRequest.html

Index: chrome/common/extensions/docs/extensions/webRequest.html
diff --git a/chrome/common/extensions/docs/extensions/webRequest.html b/chrome/common/extensions/docs/extensions/webRequest.html
index 3185d2d0f51a269f49be3e2e215caf7a47fada45..aee63f66129a61f12859a40f7605fca86134b876 100644
--- a/chrome/common/extensions/docs/extensions/webRequest.html
+++ b/chrome/common/extensions/docs/extensions/webRequest.html
@@ -1766,6 +1766,89 @@ samples</a>.</p>
               </div><div>
                 <div>
           <dt>
+            <var>postData</var>
+              <em>
+                <!-- TYPE -->
+                <div style="display:inline">
+                  (
+                    <span class="optional">optional</span>
+                    <span id="typeTemplate">
+                      <span>
+                        <span>object</span>
+                      </span>
+                    </span>
+                  )
+                </div>
+              </em>
+          </dt>
+          <dd>Experimental feature. Container for representations of data sent by the request via POST method. Only provided if extraInfoSpec contains 'postData'.</dd>
+          <!-- OBJECT PROPERTIES -->
+          <dd>
+            <dl>
+              <div>
+                <div>
+          <dt>
+            <var>error</var>
+              <em>
+                <!-- TYPE -->
+                <div style="display:inline">
+                  (
+                    <span class="optional">optional</span>
+                    <span class="enum">enumerated</span>
+                    <span id="typeTemplate">
+                      <span>
+                        <span>string</span>
+                        <span>["chunked_encoding"]</span>
+                      </span>
+                    </span>
+                  )
+                </div>
+              </em>
+          </dt>
+          <dd>Errors when obtaining POST data: 'chunked_encoding' means that the data was uploaded chunked, which is not currently supported by WebRequest.</dd>

[wtc, 2012/08/01 17:24:41]

Since 'postData' is made available to onBeforeRequest
listeners, the use of past tense "the data was uploaded chunked"
here sounds strange because the data hasn't been uploaded
yet.

Same issue with line 1832 below "the form upload was chunked".

[vabr (Chromium), 2012/08/02 09:15:15]

Done.

+          <!-- OBJECT PROPERTIES -->
+          <!-- OBJECT METHODS -->
+          <!-- OBJECT EVENT FIELDS -->
+          <!-- FUNCTION PARAMETERS -->
+        </div>
+              </div><div>
+                <div>
+          <dt>
+            <var>formData</var>
+              <em>
+                <!-- TYPE -->
+                <div style="display:inline">
+                  (
+                    <span class="optional">optional</span>
+                    <span id="typeTemplate">
+                      <span>
+                        <span>object</span>
+                      </span>
+                    </span>
+                  )
+                </div>
+              </em>
+          </dt>
+          <dd>If the POST data is a sequence of key-value pairs, either in multipart/form-data, or application/x-www-form-urlencoded, this dictionary is present and for each key contains the list of all values for that key. If the data is in another encoding, or if it was malformed, the dictionary is not present. It is also not present if the form upload was chunked. Example value of this dictionary is {'key': ['value1', 'value2']}.</dd>

[wtc, 2012/08/01 17:24:41]

Nit: encoding => media type

(I assume you meant "media type" here.)

because "encoding" can also refer to character encoding,
content encoding, or transfer encoding.

[vabr (Chromium), 2012/08/02 09:15:15]

Done.

+          <!-- OBJECT PROPERTIES -->
+          <dd>
+            <dl>
+            </dl>
+          </dd>
+          <!-- OBJECT METHODS -->
+          <!-- OBJECT EVENT FIELDS -->
+          <!-- FUNCTION PARAMETERS -->
+        </div>
+              </div>
+            </dl>
+          </dd>
+          <!-- OBJECT METHODS -->
+          <!-- OBJECT EVENT FIELDS -->
+          <!-- FUNCTION PARAMETERS -->
+        </div>
+              </div><div>
+                <div>
+          <dt>
             <var>tabId</var>
               <em>
                 <!-- TYPE -->
@@ -1886,7 +1969,7 @@ samples</a>.</p>
                           array of <span><span>
                       <span>
                         <span>string</span>
-                        <span>["blocking"]</span>
+                        <span>["blocking", "postData"]</span>
                       </span>
                     </span></span>
                         </span>