Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 10694055: Add read-only access to POST data for webRequest's onBeforeRequest (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/web_request/web_request_api.h" 5 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
11 #include "base/metrics/histogram.h" 11 #include "base/metrics/histogram.h"
12 #include "base/string_number_conversions.h" 12 #include "base/string_number_conversions.h"
13 #include "base/string_util.h" 13 #include "base/string_util.h"
14 #include "base/time.h" 14 #include "base/time.h"
15 #include "base/utf_string_conversions.h" 15 #include "base/utf_string_conversions.h"
16 #include "base/values.h" 16 #include "base/values.h"
17 #include "chrome/browser/browser_process.h" 17 #include "chrome/browser/browser_process.h"
18 #include "chrome/browser/chrome_content_browser_client.h" 18 #include "chrome/browser/chrome_content_browser_client.h"
19 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h " 19 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h "
20 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_ registry.h" 20 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_ registry.h"
21 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api_helper s.h" 21 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api_helper s.h"
22 #include "chrome/browser/extensions/api/web_request/post_data_parser.h"
22 #include "chrome/browser/extensions/api/web_request/web_request_api_constants.h" 23 #include "chrome/browser/extensions/api/web_request/web_request_api_constants.h"
23 #include "chrome/browser/extensions/api/web_request/web_request_api_helpers.h" 24 #include "chrome/browser/extensions/api/web_request/web_request_api_helpers.h"
24 #include "chrome/browser/extensions/api/web_request/web_request_time_tracker.h" 25 #include "chrome/browser/extensions/api/web_request/web_request_time_tracker.h"
25 #include "chrome/browser/extensions/event_router.h" 26 #include "chrome/browser/extensions/event_router.h"
26 #include "chrome/browser/extensions/extension_info_map.h" 27 #include "chrome/browser/extensions/extension_info_map.h"
27 #include "chrome/browser/extensions/extension_prefs.h" 28 #include "chrome/browser/extensions/extension_prefs.h"
28 #include "chrome/browser/extensions/extension_service.h" 29 #include "chrome/browser/extensions/extension_service.h"
29 #include "chrome/browser/extensions/extension_tab_id_map.h" 30 #include "chrome/browser/extensions/extension_tab_id_map.h"
30 #include "chrome/browser/profiles/profile.h" 31 #include "chrome/browser/profiles/profile.h"
31 #include "chrome/browser/profiles/profile_manager.h" 32 #include "chrome/browser/profiles/profile_manager.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 base::Uint64ToString(request->identifier())); 151 base::Uint64ToString(request->identifier()));
151 out->SetString(keys::kUrlKey, request->url().spec()); 152 out->SetString(keys::kUrlKey, request->url().spec());
152 out->SetString(keys::kMethodKey, request->method()); 153 out->SetString(keys::kMethodKey, request->method());
153 out->SetInteger(keys::kFrameIdKey, frame_id_for_extension); 154 out->SetInteger(keys::kFrameIdKey, frame_id_for_extension);
154 out->SetInteger(keys::kParentFrameIdKey, parent_frame_id_for_extension); 155 out->SetInteger(keys::kParentFrameIdKey, parent_frame_id_for_extension);
155 out->SetInteger(keys::kTabIdKey, tab_id); 156 out->SetInteger(keys::kTabIdKey, tab_id);
156 out->SetString(keys::kTypeKey, helpers::ResourceTypeToString(resource_type)); 157 out->SetString(keys::kTypeKey, helpers::ResourceTypeToString(resource_type));
157 out->SetDouble(keys::kTimeStampKey, base::Time::Now().ToDoubleT() * 1000); 158 out->SetDouble(keys::kTimeStampKey, base::Time::Now().ToDoubleT() * 1000);
158 } 159 }
159 160
161 // Extracts the POST data from |request| and writes the data into |out|.
162 // This can be expensive, so it's separated from ExtractRequestInfo().
163 void ExtractRequestInfoPost(const net::URLRequest* request,
164 DictionaryValue* out) {
165 if (request->method() != "POST")
166 return; // Need to exit without "out->Set(keys::kPostDataKey, ...);" .
167
168 DictionaryValue* post_data = new DictionaryValue();
169 out->Set(keys::kPostDataKey, post_data);
170
171 // Chunked encoding (defined in RFC 2616) is currently not supported.
172 std::string transfer_encoding;
173 if (request->extra_request_headers().GetHeader(
174 net::HttpRequestHeaders::kTransferEncoding, &transfer_encoding)) {
175 if (base::strcasecmp(transfer_encoding.c_str(), "chunked") == 0) {
176 post_data->SetString(keys::kPostDataErrorKey, "chunked_encoding");
177 return;
178 }
179 }
180
181 scoped_ptr<DictionaryValue> form_data =
182 extensions::PostDataParser::ParseURLRequestData(request);
183 if (form_data.get() != NULL)
184 post_data->Set(keys::kFormDataKey, form_data.release());
185 }
186
160 // Converts a HttpHeaders dictionary to a |name|, |value| pair. Returns 187 // Converts a HttpHeaders dictionary to a |name|, |value| pair. Returns
161 // true if successful. 188 // true if successful.
162 bool FromHeaderDictionary(const DictionaryValue* header_value, 189 bool FromHeaderDictionary(const DictionaryValue* header_value,
163 std::string* name, 190 std::string* name,
164 std::string* value) { 191 std::string* value) {
165 if (!header_value->GetString(keys::kHeaderNameKey, name)) 192 if (!header_value->GetString(keys::kHeaderNameKey, name))
166 return false; 193 return false;
167 194
168 // We require either a "value" or a "binaryValue" entry. 195 // We require either a "value" or a "binaryValue" entry.
169 if (!(header_value->HasKey(keys::kHeaderValueKey) ^ 196 if (!(header_value->HasKey(keys::kHeaderValueKey) ^
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 return false; 429 return false;
403 430
404 if (str == "requestHeaders") 431 if (str == "requestHeaders")
405 *extra_info_spec |= REQUEST_HEADERS; 432 *extra_info_spec |= REQUEST_HEADERS;
406 else if (str == "responseHeaders") 433 else if (str == "responseHeaders")
407 *extra_info_spec |= RESPONSE_HEADERS; 434 *extra_info_spec |= RESPONSE_HEADERS;
408 else if (str == "blocking") 435 else if (str == "blocking")
409 *extra_info_spec |= BLOCKING; 436 *extra_info_spec |= BLOCKING;
410 else if (str == "asyncBlocking") 437 else if (str == "asyncBlocking")
411 *extra_info_spec |= ASYNC_BLOCKING; 438 *extra_info_spec |= ASYNC_BLOCKING;
439 else if (str == "postData")
440 *extra_info_spec |= POST_DATA;
412 else 441 else
413 return false; 442 return false;
414 443
415 // BLOCKING and ASYNC_BLOCKING are mutually exclusive. 444 // BLOCKING and ASYNC_BLOCKING are mutually exclusive.
416 if ((*extra_info_spec & BLOCKING) && (*extra_info_spec & ASYNC_BLOCKING)) 445 if ((*extra_info_spec & BLOCKING) && (*extra_info_spec & ASYNC_BLOCKING))
417 return false; 446 return false;
418 } 447 }
419 return true; 448 return true;
420 } 449 }
421 450
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 520
492 int extra_info_spec = 0; 521 int extra_info_spec = 0;
493 std::vector<const EventListener*> listeners = 522 std::vector<const EventListener*> listeners =
494 GetMatchingListeners(profile, extension_info_map, keys::kOnBeforeRequest, 523 GetMatchingListeners(profile, extension_info_map, keys::kOnBeforeRequest,
495 request, &extra_info_spec); 524 request, &extra_info_spec);
496 if (!listeners.empty() && 525 if (!listeners.empty() &&
497 !GetAndSetSignaled(request->identifier(), kOnBeforeRequest)) { 526 !GetAndSetSignaled(request->identifier(), kOnBeforeRequest)) {
498 ListValue args; 527 ListValue args;
499 DictionaryValue* dict = new DictionaryValue(); 528 DictionaryValue* dict = new DictionaryValue();
500 ExtractRequestInfo(request, dict); 529 ExtractRequestInfo(request, dict);
530 if (extra_info_spec & ExtraInfoSpec::POST_DATA)
531 ExtractRequestInfoPost(request, dict);
501 args.Append(dict); 532 args.Append(dict);
502 533
503 initialize_blocked_requests |= 534 initialize_blocked_requests |=
504 DispatchEvent(profile, request, listeners, args); 535 DispatchEvent(profile, request, listeners, args);
505 } 536 }
506 537
507 if (!initialize_blocked_requests) 538 if (!initialize_blocked_requests)
508 return net::OK; // Nobody saw a reason for modifying the request. 539 return net::OK; // Nobody saw a reason for modifying the request.
509 540
510 blocked_requests_[request->identifier()].event = kOnBeforeRequest; 541 blocked_requests_[request->identifier()].event = kOnBeforeRequest;
(...skipping 1309 matching lines...) Expand 10 before | Expand all | Expand 10 after
1820 } else if ((*it)->name().find("AdBlock") != std::string::npos) { 1851 } else if ((*it)->name().find("AdBlock") != std::string::npos) {
1821 adblock = true; 1852 adblock = true;
1822 } else { 1853 } else {
1823 other = true; 1854 other = true;
1824 } 1855 }
1825 } 1856 }
1826 } 1857 }
1827 1858
1828 host->Send(new ExtensionMsg_UsingWebRequestAPI(adblock, adblock_plus, other)); 1859 host->Send(new ExtensionMsg_UsingWebRequestAPI(adblock, adblock_plus, other));
1829 } 1860 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698