Add read-only access to POST data for webRequest's onBeforeRequest

chrome/test/data/extensions/api_test/webrequest/test_post.js

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var dirName = "requestBody/";
+
+function sendPost(formFile, ParseableForm) {

[battre, 2012/08/16 19:18:03]

nit: parseableForm should start with a lower case letter

[vabr (Chromium), 2012/08/17 18:29:57]

Done.

+  // The following variables must be updated when files in |dirName| change.
+  var formData = {
+      check: ["option_A"],
+      password: ["password"],
+      radio: ["Yes"],
+      select: ["one"],
+      text1: ["TEST_TEXT_1"],
+      text2: ["TEST_TEXT_2"],
+      text3: ["TEST_TEXT_3"],
+      txtarea: ["Text"]
+  };
+  return function submitForm() {
+    expect(
+      [  // events
+        { label: "a-onBeforeRequest",
+          event: "onBeforeRequest",
+          details: {
+            method: "GET",
+            type: "main_frame",
+            url: getURL(dirName + formFile),
+            frameUrl: getURL(dirName + formFile)
+          }
+        },
+        { label: "a-onResponseStarted",
+          event: "onResponseStarted",
+          details: {
+            fromCache: false,
+            method: "GET",
+            statusCode: 200,
+            statusLine: "HTTP/1.1 200 OK",
+            type: "main_frame",
+            url: getURL(dirName + formFile)
+          }
+        },
+        { label: "a-onCompleted",
+          event: "onCompleted",
+          details: {
+            fromCache: false,
+            method: "GET",
+            statusCode: 200,
+            statusLine: "HTTP/1.1 200 OK",
+            type: "main_frame",
+            url: getURL(dirName + formFile)
+          }
+        },
+        { label: "s-onBeforeRequest",
+          event: "onBeforeRequest",
+          details: {
+            method: "GET",
+            type: "script",
+            url: getURL("requestBody/submit.js"),
+            frameUrl: getURL(dirName + formFile)
+          }
+        },
+        { label: "s-onResponseStarted",
+          event: "onResponseStarted",
+          details: {
+            fromCache: false,
+            method: "GET",
+            statusCode: 200,
+            statusLine: "HTTP/1.1 200 OK",
+            type: "script",
+            url: getURL("requestBody/submit.js")
+          }
+        },
+        { label: "s-onCompleted",
+          event: "onCompleted",
+          details: {
+            fromCache: false,
+            method: "GET",
+            statusCode: 200,
+            statusLine: "HTTP/1.1 200 OK",
+            type: "script",
+            url: getURL("requestBody/submit.js")
+          }
+        },
+        { label: "b-onBeforeRequest",
+          event: "onBeforeRequest",
+          details: {
+            method: "POST",
+            type: "main_frame",
+            url: getURL("requestBody/nonExistingTarget.html"),
+            frameUrl: getURL("requestBody/nonExistingTarget.html"),
+            requestBody: ParseableForm ? {
+              formData: formData
+            } : {
+              raw: [ { byteLength: 127 } ]

[battre, 2012/08/16 19:18:03]

why does this contain only the byteLength? I thought you pass this as an array?

[vabr (Chromium), 2012/08/17 18:29:57]

I pass it as ArrayBuffer. I don't think its value can be represented in JSON,
even in Javascript you need adaptor classes to view it, which specify the number
of bytes per elements. The byteLength property is however visible, and while not
allowing to test byte-equality, it at least tests that the ArrayBuffer is there.
Also, the byte-equality at least on the C++ side is tested in the unit-tests.

+            }
+          }
+        },
+        { label: "b-onErrorOccurred",
+          event: "onErrorOccurred",
+          details: {
+            error: "net::ERR_FILE_NOT_FOUND",
+            fromCache: false,
+            method: "POST",
+            type: "main_frame",
+            url: getURL("requestBody/nonExistingTarget.html")
+          }
+        }
+      ],
+      [  // event order
+        ["a-onBeforeRequest", "a-onResponseStarted", "a-onCompleted",
+        "s-onBeforeRequest", "s-onResponseStarted", "s-onCompleted",
+        "b-onBeforeRequest", "b-onErrorOccurred"]
+      ],
+      {urls: ["<all_urls>"]},  // filter
+      ["requestBody"]);
+    navigateAndWait(getURL(dirName + formFile));

[battre, 2012/08/16 19:18:03]

this should be
navigateAndWait(getURL(...), function() {close();}); such that close is executed
when the navigation is completed.

[vabr (Chromium), 2012/08/17 18:29:57]

Done.
Thanks, I did not know that!

+    close();
+  }
+}
+
+runTests([
+  // Navigates to a page with a form and submits it, generating a POST request.
+  // First two result in url-encoded form.
+  sendPost('no-enctype.html', true),
+  sendPost('urlencoded.html', true),
+  // Third results in multipart-encoded form.
+  sendPost('multipart.html', true),
+  // Fourth results in unparseable form, and thus raw data string.
+  sendPost('plaintext.html', false),
+]);