Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/browser/resources/safe_browsing_multiple_threat_block.html

Issue 10694037: Add a policy to disable proceeding through the Safe Browsing interstitials. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/safe_browsing_multiple_threat_block.html
diff --git a/chrome/browser/resources/safe_browsing_multiple_threat_block.html b/chrome/browser/resources/safe_browsing_multiple_threat_block.html
index 40dd0c4efea99375a18ca0e2d6962e5deecea868..b826e2848cae9b4fa032f56e64d3b9219b140359 100644
--- a/chrome/browser/resources/safe_browsing_multiple_threat_block.html
+++ b/chrome/browser/resources/safe_browsing_multiple_threat_block.html
@@ -87,34 +87,36 @@ function sendCommand(command) {
window.domAutomationController.send(command);
}
-function showDiagnostic(errorID) {
- sendCommand("showDiagnostic:" + errorID);
-}
-
-function reportError(errorID) {
- sendCommand("reportError:" + errorID);
-}
-
function learnMore() {
- sendCommand("learnMore");
+ sendCommand('learnMore');
}
function proceed() {
- sendCommand("proceed");
+ sendCommand('proceed');
}
function takeMeBack() {
- sendCommand("takeMeBack");
+ sendCommand('takeMeBack');
+}
+
+function showOrReport() {
+ var id = this.getAttribute('chromiumID');
+ var isMalware = this.getAttribute('chromiumIsMalware');
+ var cmd = isMalware ? 'showDiagnostic:' : 'reportError:';
+ sendCommand(cmd + id);
+ return false;
}
</script>
</head>
<body oncontextmenu="return false;">
-<div class="background"><img src="ssl_roadblock_background.png" width="100%" height="100%" alt="background" onmousedown="return false;"/></div>
+<div class="background"><img src="ssl_roadblock_background.png" width="100%"
+ height="100%" alt="background" onmousedown="return false;"/></div>
<table width="100%" cellspacing="0" cellpadding="0">
<td class="cell" valign="middle" align="center">
<div class="box">
- <div class="icon"><img src="shared/images/phishing_icon.png" alt="Malware Icon" onmousedown="return false;"/></div>
+ <div class="icon"><img src="shared/images/phishing_icon.png"
+ alt="Malware Icon" onmousedown="return false;"/></div>
<div class="title" i18n-content="headLine"></div>
<div class="main" i18n-values=".innerHTML:description1"></div>
<div class="main" i18n-content="description2"></div>
@@ -123,17 +125,28 @@ function takeMeBack() {
<tr jsselect="errors" class="errorlist">
<td jscontent="typeLabel"></td>
<td jscontent="url"></td>
- <td><a href="" onclick="var id= this.getAttribute('chromiumID'); this.getAttribute('chromiumIsMalware') ? showDiagnostic(id) : reportError(id); return false;" jscontent="errorLink" jsvalues="chromiumID:$counter.value;chromiumIsMalware:type=='malware'" jseval="$counter.value++"></a></td>
+ <td><a href="" onclick="showOrReport()"
+ jsvalues="chromiumID:$counter.value;chromiumIsMalware:type=='malware'"
Joao da Silva 2012/07/02 10:08:40 Any hint on how to break this one into 80 cols? Sh
+ jscontent="errorLink" jseval="$counter.value++"></a></td>
</tr>
</table>
</div>
- <div class="main"><a href="" i18n-content="description3" onclick="learnMore(); return false;" onmousedown="return false;"></a></div>
+ <div class="main"><a href="" i18n-content="description3"
+ onclick="learnMore(); return false;"
+ onmousedown="return false;"></a></div>
<div class="main">
<form class="submission">
- <input name="checky" id="checky" type="checkbox" onclick="agreed(this.form)">&nbsp;<label for="checky" i18n-content="confirm_text"></label>
- <input type="button" name="continue_button" i18n-values="value:continue_button" disabled="true" onclick="proceed();"><br>
- <input type="button" name="back_button" i18n-values="value:back_button" onclick="takeMeBack()">
+ <input name="checky" id="checky" type="checkbox"
+ jsdisplay="!proceedDisabled"
+ onclick="agreed(this.form)">&nbsp;
+ <label for="checky" i18n-content="confirm_text"
+ jsdisplay="!proceedDisabled"></label>
+ <button name="continue_button" i18n-values="value:continue_button"
+ disabled="true" jsdisplay="!proceedDisabled"
+ onclick="proceed();"><br>
+ <button name="back_button" i18n-values="value:back_button"
+ onclick="takeMeBack()">
</form>
</div>
</div>
« no previous file with comments | « chrome/browser/resources/safe_browsing_malware_block.html ('k') | chrome/browser/resources/safe_browsing_phishing_block.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698