Chromium Code Reviews Chromium Code Reviews
Issue 10694013:
Shade uninitialized about:sync fields (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_ | 5 #ifndef SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_ |
| 6 #define SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_ | 6 #define SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_ |
| 7 #pragma once | 7 #pragma once |
| 8 | 8 |
| 9 #include <string> | 9 #include <string> |
| 10 | 10 |
| (...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 65 int num_encryption_conflicts() const; | 65 int num_encryption_conflicts() const; |
| 66 int num_hierarchy_conflicts() const; | 66 int num_hierarchy_conflicts() const; |
| 67 int num_simple_conflicts() const; | 67 int num_simple_conflicts() const; |
| 68 int num_server_conflicts() const; | 68 int num_server_conflicts() const; |
| 69 SyncSourceInfo source() const; | 69 SyncSourceInfo source() const; |
| 70 bool notifications_enabled() const; | 70 bool notifications_enabled() const; |
| 71 size_t num_entries() const; | 71 size_t num_entries() const; |
| 72 base::Time sync_start_time() const; | 72 base::Time sync_start_time() const; |
| 73 bool retry_scheduled() const; | 73 bool retry_scheduled() const; |
| 74 | 74 |
| 75 // Set iff this snapshot was built using the default constructor. | |
|
akalin
2012/07/02 21:18:25
don't you mean 'not built'?
rlarocque
2012/07/02 21:50:26
Correct. I negated the logic of this flag at one
| |
| 76 bool is_initialized() const; | |
| 77 | |
| 75 private: | 78 private: |
| 76 ModelNeutralState model_neutral_state_; | 79 ModelNeutralState model_neutral_state_; |
| 77 bool is_share_usable_; | 80 bool is_share_usable_; |
| 78 syncable::ModelTypeSet initial_sync_ended_; | 81 syncable::ModelTypeSet initial_sync_ended_; |
| 79 syncable::ModelTypePayloadMap download_progress_markers_; | 82 syncable::ModelTypePayloadMap download_progress_markers_; |
| 80 bool has_more_to_sync_; | 83 bool has_more_to_sync_; |
| 81 bool is_silenced_; | 84 bool is_silenced_; |
| 82 int num_encryption_conflicts_; | 85 int num_encryption_conflicts_; |
| 83 int num_hierarchy_conflicts_; | 86 int num_hierarchy_conflicts_; |
| 84 int num_simple_conflicts_; | 87 int num_simple_conflicts_; |
| 85 int num_server_conflicts_; | 88 int num_server_conflicts_; |
| 86 SyncSourceInfo source_; | 89 SyncSourceInfo source_; |
| 87 bool notifications_enabled_; | 90 bool notifications_enabled_; |
| 88 size_t num_entries_; | 91 size_t num_entries_; |
| 89 base::Time sync_start_time_; | 92 base::Time sync_start_time_; |
| 90 bool retry_scheduled_; | 93 bool retry_scheduled_; |
| 94 | |
| 95 bool is_initialized_; | |
| 91 }; | 96 }; |
| 92 | 97 |
| 93 } // namespace sessions | 98 } // namespace sessions |
| 94 } // namespace syncer | 99 } // namespace syncer |
| 95 | 100 |
| 96 #endif // SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_ | 101 #endif // SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_ |
| OLD | NEW |
