Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/sync/sync_ui_util.h

Issue 10694013: Shade uninitialized about:sync fields (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix one more test error Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_ 5 #ifndef CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_
6 #define CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_ 6 #define CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 string16* bubble_accept_label); 66 string16* bubble_accept_label);
67 67
68 MessageType GetStatus(ProfileSyncService* service, const SigninManager& signin); 68 MessageType GetStatus(ProfileSyncService* service, const SigninManager& signin);
69 69
70 // Returns a string with the synchronization status. 70 // Returns a string with the synchronization status.
71 string16 GetSyncMenuLabel(ProfileSyncService* service, 71 string16 GetSyncMenuLabel(ProfileSyncService* service,
72 const SigninManager& signin); 72 const SigninManager& signin);
73 73
74 void AddBoolSyncDetail(base::ListValue* details, 74 void AddBoolSyncDetail(base::ListValue* details,
75 const std::string& stat_name, 75 const std::string& stat_name,
76 bool stat_value); 76 bool stat_value,
77 bool is_valid);
77 78
78 // |service| can be NULL. 79 // |service| can be NULL.
79 void ConstructAboutInformation(ProfileSyncService* service, 80 void ConstructAboutInformation(ProfileSyncService* service,
80 DictionaryValue* strings); 81 DictionaryValue* strings);
81 82
82 void AddIntSyncDetail(base::ListValue* details, 83 void AddIntSyncDetail(base::ListValue* details,
83 const std::string& stat_name, 84 const std::string& stat_name,
84 int64 stat_value); 85 int64 stat_value,
86 bool is_valid);
85 87
86 void AddStringSyncDetails(ListValue* details, const std::string& stat_name, 88 void AddStringSyncDetails(ListValue* details, const std::string& stat_name,
87 const std::string& stat_value); 89 const std::string& stat_value, bool is_valid);
88 90
89 // Returns a string describing the chrome version environment. Version format: 91 // Returns a string describing the chrome version environment. Version format:
90 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel"> 92 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel">
91 // If version information is unavailable, returns "invalid." 93 // If version information is unavailable, returns "invalid."
92 // TODO(zea): this approximately matches MakeUserAgentForSyncApi in 94 // TODO(zea): this approximately matches MakeUserAgentForSyncApi in
93 // sync_backend_host.cc. Unify the two if possible. 95 // sync_backend_host.cc. Unify the two if possible.
94 std::string GetVersionString(); 96 std::string GetVersionString();
95 97
96 } // namespace sync_ui_util 98 } // namespace sync_ui_util
97 #endif // CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_ 99 #endif // CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698