Add support for loading user cloud policy on desktop.

chrome/browser/policy/user_cloud_policy_manager.h

Index: chrome/browser/policy/user_cloud_policy_manager.h
diff --git a/chrome/browser/policy/user_cloud_policy_manager.h b/chrome/browser/policy/user_cloud_policy_manager.h
index 8db19d03274f47c1be9e8bba9c9c2ca67fa578bc..98c59e2670f508478aa0f54cbefda4edfe388851 100644
--- a/chrome/browser/policy/user_cloud_policy_manager.h
+++ b/chrome/browser/policy/user_cloud_policy_manager.h
@@ -13,6 +13,7 @@
 #include "chrome/browser/policy/configuration_policy_provider.h"
 
 class PrefService;
+class Profile;
 
 namespace policy {
 
@@ -33,23 +34,32 @@ class UserCloudPolicyManager : public ConfigurationPolicyProvider,
                          bool wait_for_policy_fetch);
   virtual ~UserCloudPolicyManager();
 
-#if defined(OS_CHROMEOS)
-  // Creates a UserCloudPolicyService instance for the Chrome OS platform.
-  static scoped_ptr<UserCloudPolicyManager> Create(bool wait_for_policy_fetch);
-#endif
+  // Creates a UserCloudPolicyService instance associated with the passed
+  // |profile|.
+  static scoped_ptr<UserCloudPolicyManager> Create(Profile* profile,
+                                                   bool wait_for_policy_fetch);
 
-  // Initializes the cloud connection. |prefs| and |service| must stay valid
-  // until Shutdown() gets called.
-  void Initialize(PrefService* prefs,
-                  DeviceManagementService* service,
-                  UserAffiliation user_affiliation);
-  void Shutdown();
+  // Initializes the cloud connection. |local_prefs| and |service| must stay
+  // valid until Shutdown() gets called. Virtual for mocking.
+  virtual void Initialize(PrefService* local_prefs,

[Mattias Nissler (ping if slow), 2012/08/03 12:19:08]

Wait, are you passing g_browser_process->local_state() here? That is incorrect
as the Profile PrefService can have different policy than local_state.

[Andrew T Wilson (Slow), 2012/08/04 00:54:41]

As far as I can tell, the only thing local_state is used for is to pull in
kUserPolicyRefreshRate, which lives in the local prefs. Honestly, it probably
would be better to have the refresh rate passed in, rather than plumb the
local_prefs all the way down into CloudPolicyRefreshScheduler. What do you
think?

The prefs accessed by by the CloudPolicyStore are still the profile prefs (they
are pulled directly from the profile in Create()).

[Mattias Nissler (ping if slow), 2012/08/06 08:33:52]

Ah, correct, I was mistaken. FWIW, in the future we might have different refresh
rates for different Profile instances in case each Profile has its own policy.
In that case we'd have to read from the profile PrefService. Nothing to worry
about right now though.

Honestly, it probably
You can do that as well, but then you need an external entity that reacts to
pref changes and updates the value.
 

[Andrew T Wilson (Slow), 2012/08/06 20:30:23]

Hmmm. Good point (or we could ignore policy polling frequency changes until the
next restart). But I agree we're fine for now.

+                          DeviceManagementService* service,
+                          UserAffiliation user_affiliation);
+
+  // Virtual for mocks.
+  virtual void Shutdown();
 
   // Cancels waiting for the policy fetch and flags the
   // ConfigurationPolicyProvider ready (assuming all other initialization tasks
   // have completed).
   void CancelWaitForPolicyFetch();
 
+  // Returns true if the underlying CloudPolicyClient is already registered.
+  // Virtual for mocking.
+  virtual bool IsClientRegistered() const;
+
+  // Register the CloudPolicyClient using the passed OAuth token.
+  void RegisterClient(const std::string& access_token);
+
   CloudPolicyService* cloud_policy_service() { return service_.get(); }
 
   // ConfigurationPolicyProvider: