Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 10692178: Revert revert of 146149 - Don't pass the connector check policy flag along. (Closed)

Created:
8 years, 5 months ago by Scott Byer
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert revert of 146149 - Don't pass the connector check policy flag along. If a browser is running, and the service process is running the connector, the connector will occasionally start up a chromium process to check the connector enablement policy. The flag to do so would get passed to a running browser, if present, and there is a path through the policy check code that could cause the browser to quit. This patch prevents the policy check flag from being passed on; the started process will be very short lived and does a silent launch. Original Review URL: https://chromiumcodereview.appspot.com/10666010 BUG=134252 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148676

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : Test should not run on chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -4 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
A chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_result_codes.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Byer
This is a slight tweak of https://chromiumcodereview.appspot.com/10666010, which had to be reverted. The new test ...
8 years, 5 months ago (2012-07-26 18:57:35 UTC) #1
Lei Zhang
lgtm
8 years, 5 months ago (2012-07-26 19:32:36 UTC) #2
Albert Bodenhamer
lgtm
8 years, 5 months ago (2012-07-26 21:00:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/10692178/11001
8 years, 5 months ago (2012-07-26 21:10:15 UTC) #4
commit-bot: I haz the power
Try job failure for 10692178-11001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 22:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/10692178/11001
8 years, 5 months ago (2012-07-26 22:07:47 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-27 00:41:26 UTC) #7
Change committed as 148676

Powered by Google App Engine
This is Rietveld 408576698