Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10692170: Aura desktop: Show resize cursors again. (Closed)

Created:
8 years, 5 months ago by Elliot Glaysher
Modified:
8 years, 5 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Aura desktop: Show resize cursors again. This moves CursorManager into ash/wm/ and makes it an implementation of a new CursorClient interface. It's really an implementation detail of ash. Then create a desktop version of this interface. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148454

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Patch Set 3 : fix gyp #

Patch Set 4 : Fix chromeos compile #

Patch Set 5 : fix win_aura compile #

Total comments: 3

Patch Set 6 : IsCursorVisible() #

Patch Set 7 : Rebase to ToT #

Total comments: 1

Patch Set 8 : explicit #

Patch Set 9 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -234 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shell.h View 1 2 3 4 5 6 4 chunks +6 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 8 5 chunks +4 lines, -5 lines 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/cursor_delegate.h View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
A + ash/wm/cursor_manager.h View 1 2 3 4 5 6 2 chunks +10 lines, -7 lines 0 comments Download
A + ash/wm/cursor_manager.cc View 1 2 3 4 5 2 chunks +8 lines, -4 lines 0 comments Download
M ash/wm/default_window_resizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/power_button_controller.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/power_button_controller_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 3 chunks +9 lines, -3 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
A ui/aura/client/cursor_client.h View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
A ui/aura/client/cursor_client.cc View 1 chunk +28 lines, -0 lines 0 comments Download
D ui/aura/cursor_delegate.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
D ui/aura/cursor_manager.h View 1 2 3 4 5 6 1 chunk +0 lines, -59 lines 0 comments Download
D ui/aura/cursor_manager.cc View 1 chunk +0 lines, -58 lines 0 comments Download
A ui/aura/desktop/desktop_cursor_client.h View 1 2 3 4 5 6 7 1 chunk +36 lines, -0 lines 0 comments Download
A ui/aura/desktop/desktop_cursor_client.cc View 1 2 3 4 5 1 chunk +30 lines, -0 lines 0 comments Download
M ui/aura/env.h View 1 2 3 4 5 6 3 chunks +0 lines, -5 lines 0 comments Download
M ui/aura/env.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/shared/compound_event_filter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/shared/compound_event_filter.cc View 1 2 3 4 5 6 5 chunks +24 lines, -14 lines 0 comments Download
M ui/aura/shared/compound_event_filter_unittest.cc View 1 2 3 4 5 3 chunks +30 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_native_widget_helper_aura.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_native_widget_helper_aura.cc View 1 2 3 4 5 6 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Elliot Glaysher
8 years, 5 months ago (2012-07-11 23:20:49 UTC) #1
oshima
lgtm with a few minor comments. http://codereview.chromium.org/10692170/diff/5002/chrome/browser/ui/views/extensions/extension_dialog.cc File chrome/browser/ui/views/extensions/extension_dialog.cc (right): http://codereview.chromium.org/10692170/diff/5002/chrome/browser/ui/views/extensions/extension_dialog.cc#newcode126 chrome/browser/ui/views/extensions/extension_dialog.cc:126: #if defined(USE_ASH) This ...
8 years, 5 months ago (2012-07-11 23:32:08 UTC) #2
Elliot Glaysher
ben: ui stamp http://codereview.chromium.org/10692170/diff/5002/chrome/browser/ui/views/extensions/extension_dialog.cc File chrome/browser/ui/views/extensions/extension_dialog.cc (right): http://codereview.chromium.org/10692170/diff/5002/chrome/browser/ui/views/extensions/extension_dialog.cc#newcode126 chrome/browser/ui/views/extensions/extension_dialog.cc:126: #if defined(USE_ASH) On 2012/07/11 23:32:08, oshima ...
8 years, 5 months ago (2012-07-12 18:16:44 UTC) #3
Elliot Glaysher
On 2012/07/12 18:16:44, Elliot Glaysher wrote: > ben: ui stamp > > http://codereview.chromium.org/10692170/diff/5002/chrome/browser/ui/views/extensions/extension_dialog.cc > File ...
8 years, 5 months ago (2012-07-25 17:06:10 UTC) #4
Elliot Glaysher
+ben for stamp. note to self: next time I get cranky about Ben not doing ...
8 years, 5 months ago (2012-07-25 19:37:16 UTC) #5
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10692170/diff/14001/ui/aura/desktop/desktop_cursor_client.h File ui/aura/desktop/desktop_cursor_client.h (right): http://codereview.chromium.org/10692170/diff/14001/ui/aura/desktop/desktop_cursor_client.h#newcode20 ui/aura/desktop/desktop_cursor_client.h:20: DesktopCursorClient(aura::RootWindow* window); explicit
8 years, 5 months ago (2012-07-25 19:49:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10692170/21002
8 years, 5 months ago (2012-07-25 19:57:51 UTC) #7
commit-bot: I haz the power
Failed to apply patch for ash/shell.cc: While running patch -p1 --forward --force; patching file ash/shell.cc ...
8 years, 5 months ago (2012-07-25 19:57:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10692170/25001
8 years, 5 months ago (2012-07-25 20:11:57 UTC) #9
commit-bot: I haz the power
Try job failure for 10692170-25001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-25 21:33:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10692170/25001
8 years, 5 months ago (2012-07-25 21:35:40 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 00:54:21 UTC) #12 
Change committed as 148454

Powered by Google App Engine
This is Rietveld 408576698