chrome/browser/extensions/api/socket/tcp_socket.h - Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/tcp_socket.h

Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix review issues Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/socket/tcp_socket.h

diff --git a/chrome/browser/extensions/api/socket/tcp_socket.h b/chrome/browser/extensions/api/socket/tcp_socket.h

index 7f677487b82478b6fc3497b4dd4aebe111ec87a2..764b5b91c9aed0fbdb132d63f40b63fa901f92ca 100644

--- a/chrome/browser/extensions/api/socket/tcp_socket.h

+++ b/chrome/browser/extensions/api/socket/tcp_socket.h

@@ -42,9 +42,9 @@ class TCPSocket : public Socket {

const CompletionCallback& callback) OVERRIDE;

virtual bool SetKeepAlive(bool enable, int delay) OVERRIDE;

virtual bool SetNoDelay(bool no_delay) OVERRIDE;

- virtual bool IsTCPSocket() OVERRIDE;

virtual bool GetPeerAddress(net::IPEndPoint* address) OVERRIDE;

virtual bool GetLocalAddress(net::IPEndPoint* address) OVERRIDE;

+ virtual Socket::SocketType socket_type() const OVERRIDE;

static TCPSocket* CreateSocketForTesting(

net::TCPClientSocket* tcp_client_socket,