chrome/browser/extensions/api/permissions/permissions_api_helpers.cc - Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix review issues Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.cc ('k') | chrome/browser/extensions/api/socket/socket.h » ('j') | chrome/browser/extensions/api/socket/socket.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

index a421a9d9071b615a78280a7692a1e0836f98d657..5bbedd7efe53687f8141d78224320c5011892363 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

@@ -35,10 +35,9 @@ scoped_ptr<Permissions> PackPermissionSet(const PermissionSet* set) {

Permissions* permissions(new Permissions());

permissions->permissions.reset(new std::vector<std::string>());

- PermissionsInfo* info = PermissionsInfo::GetInstance();

for (APIPermissionSet::const_iterator i = set->apis().begin();

i != set->apis().end(); ++i) {

- permissions->permissions->push_back(info->GetByID(*i)->name());

+ permissions->permissions->push_back(i->name());

}

permissions->origins.reset(new std::vector<std::string>());