chrome/browser/extensions/api/socket/udp_socket.cc - Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/udp_socket.cc

Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix review issues and add some unit tests Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/socket/udp_socket.cc

diff --git a/chrome/browser/extensions/api/socket/udp_socket.cc b/chrome/browser/extensions/api/socket/udp_socket.cc

index 3116d6f06b79167764dc63bc4f6cd8eeec9d4dd4..abd250110adbc277cbee01cbcebf7bf2f42fb2e0 100644

--- a/chrome/browser/extensions/api/socket/udp_socket.cc

+++ b/chrome/browser/extensions/api/socket/udp_socket.cc

@@ -185,6 +185,10 @@ void UDPSocket::SendTo(scoped_refptr<net::IOBuffer> io_buffer,

OnSendToComplete(result);

}

+Socket::SocketType UDPSocket::socket_type() const {

+ return Socket::TYPE_UDP;

void UDPSocket::OnReadComplete(scoped_refptr<net::IOBuffer> io_buffer,

int result) {

DCHECK(!read_callback_.is_null());