chrome/browser/extensions/api/socket/socket_api.h - Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/socket_api.h

Issue 10692160: Support socket endpoint permissions for AppsV2 Socket API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix review issues and add some unit tests Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/socket/socket_api.h

diff --git a/chrome/browser/extensions/api/socket/socket_api.h b/chrome/browser/extensions/api/socket/socket_api.h

index 0523b947c8a1a76838a9d43c996381da1870cf9c..5a6b18abf53e9f04d77778b1d393ecdb695ac6ce 100644

--- a/chrome/browser/extensions/api/socket/socket_api.h

+++ b/chrome/browser/extensions/api/socket/socket_api.h

@@ -125,6 +125,7 @@ class SocketConnectFunction : public SocketExtensionWithDnsLookupFunction {

int socket_id_;

std::string hostname_;

int port_;

+ Socket* socket_;

};

class SocketDisconnectFunction : public SocketAsyncApiFunction {

@@ -243,6 +244,7 @@ class SocketSendToFunction : public SocketExtensionWithDnsLookupFunction {

size_t io_buffer_size_;

std::string hostname_;

int port_;

+ Socket* socket_;

};

class SocketSetKeepAliveFunction : public SocketAsyncApiFunction {