Support socket endpoint permissions for AppsV2 Socket API.

chrome/browser/extensions/extension_prefs.cc

Index: chrome/browser/extensions/extension_prefs.cc
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc
index e2ed4ea0e9b6caf7dfc7ddb998348ab0974e2f88..3805920b406d7d85f9e550d51d3d75e5350be79f 100644
--- a/chrome/browser/extensions/extension_prefs.cc
+++ b/chrome/browser/extensions/extension_prefs.cc
@@ -493,11 +493,24 @@ PermissionSet* ExtensionPrefs::ReadExtensionPrefPermissionSet(
   if (ReadExtensionPrefList(extension_id, api_pref, &api_values)) {
     PermissionsInfo* info = PermissionsInfo::GetInstance();
     for (size_t i = 0; i < api_values->GetSize(); ++i) {
+      const ListValue* permission_list = NULL;
       std::string permission_name;
-      if (api_values->GetString(i, &permission_name)) {
+      if (api_values->GetString(i, &permission_name) ||
+          (api_values->GetList(i, &permission_list) &&
+           permission_list->GetString(0, &permission_name))) {
         APIPermission *permission = info->GetByName(permission_name);
-        if (permission)
-          apis.insert(permission->id());
+        if (permission) {
+          const Value* tmp = NULL;
+          scoped_refptr<APIPermissionDetail> detail =
+            permission->CreateDetail();
+          if (permission_list) {
+            if (permission_list->Get(1, &tmp))
+              detail->FromValue(tmp);
+            else
+              DLOG(WARNING) << "Get detail from permission_list failed.";

[miket_OOO, 2012/08/06 21:04:06]

I haven't looked at DLOG, but beware that depending on how it's implemented it
might cause a compile error in release mode because of the else without braces.

[Peng, 2012/08/07 21:31:55]

Tested it in release build. Seems OK.

+          }
+          apis.insert(detail);
+        }
       }
     }
   }
@@ -524,13 +537,19 @@ void ExtensionPrefs::SetExtensionPrefPermissionSet(
   // Set the API permissions.
   ListValue* api_values = new ListValue();
   APIPermissionSet apis = new_value->apis();
-  PermissionsInfo* info = PermissionsInfo::GetInstance();
   std::string api_pref = JoinPrefs(pref_key, kPrefAPIs);
   for (APIPermissionSet::const_iterator i = apis.begin();
        i != apis.end(); ++i) {
-    APIPermission* perm = info->GetByID(*i);
-    if (perm)
-      api_values->Append(Value::CreateStringValue(perm->name()));
+    Value* detail = NULL;
+    i->ToValue(&detail);
+    if (!detail) {
+      api_values->Append(Value::CreateStringValue(i->name()));
+    } else {
+      ListValue* tmp = new ListValue();
+      tmp->Append(Value::CreateStringValue(i->name()));
+      tmp->Append(detail);
+      api_values->Append(tmp);
+    }
   }
   UpdateExtensionPref(extension_id, api_pref, api_values);