Support socket endpoint permissions for AppsV2 Socket API.

chrome/browser/extensions/api/socket/socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_H_
 #define CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_H_
 
 #include <queue>
 #include <string>
 #include <utility>
@@ skipping 17 matching lines @@
 typedef base::Callback<void(int, scoped_refptr<net::IOBuffer> io_buffer)>
     ReadCompletionCallback;
 typedef base::Callback<
   void(int, scoped_refptr<net::IOBuffer> io_buffer, const std::string&, int)>
       RecvFromCompletionCallback;
 
 // A Socket wraps a low-level socket and includes housekeeping information that
 // we need to manage it in the context of an extension.
 class Socket : public ApiResource {
  public:
+  enum SocketType {
+    TYPE_TCP,
+    TYPE_UDP,
+  };
+
   virtual ~Socket();
   virtual void Connect(const std::string& address,
                        int port,
                        const CompletionCallback& callback) = 0;
   virtual void Disconnect() = 0;
   virtual int Bind(const std::string& address, int port) = 0;
 
   // The |callback| will be called with the number of bytes read into the
   // buffer, or a negative number if an error occurred.
   virtual void Read(int count,
@@ skipping 10 matching lines @@
   virtual void SendTo(scoped_refptr<net::IOBuffer> io_buffer,
                       int byte_count,
                       const std::string& address,
                       int port,
                       const CompletionCallback& callback) = 0;
 
   virtual bool SetKeepAlive(bool enable, int delay);
   virtual bool SetNoDelay(bool no_delay);
 
   bool IsConnected();
-  virtual bool IsTCPSocket() = 0;
 
   virtual bool GetPeerAddress(net::IPEndPoint* address) = 0;
   virtual bool GetLocalAddress(net::IPEndPoint* address) = 0;
 
+  virtual SocketType socket_type() const = 0;

[Mihai Parparita -not on Chrome, 2012/08/14 00:53:09]

I believe that per the style guide, hacker_style naming should only be used for
simple getter/setter methods that can be inlined, and virtual methods are by
definition not that simple.

[Peng, 2012/08/14 17:43:31]

Done.

+
   static bool StringAndPortToAddressList(const std::string& ip_address_str,
                                          int port,
                                          net::AddressList* address_list);
   static bool StringAndPortToIPEndPoint(const std::string& ip_address_str,
                                         int port,
                                         net::IPEndPoint* ip_end_point);
   static void IPEndPointToStringAndPort(const net::IPEndPoint& address,
                                         std::string* ip_address_str,
                                         int* port);
 
@@ skipping 25 matching lines @@
     CompletionCallback callback;
     int bytes_written;
   };
   std::queue<WriteRequest> write_queue_;
   scoped_refptr<net::IOBuffer> io_buffer_write_;
 };
 
 }  //  namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_H_