Support socket endpoint permissions for AppsV2 Socket API.

chrome/browser/extensions/extension_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_prefs.h"
 
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/admin_policy.h"
@@ skipping 465 matching lines @@
   if (!GetExtensionPref(extension_id))
     return NULL;
 
   // Retrieve the API permissions.
   APIPermissionSet apis;
   const ListValue* api_values = NULL;
   std::string api_pref = JoinPrefs(pref_key, kPrefAPIs);
   if (ReadExtensionPrefList(extension_id, api_pref, &api_values)) {
     PermissionsInfo* info = PermissionsInfo::GetInstance();
     for (size_t i = 0; i < api_values->GetSize(); ++i) {
+      ListValue* permission_list = NULL;
       std::string permission_name;
-      if (api_values->GetString(i, &permission_name)) {
+      if (api_values->GetString(i, &permission_name) ||
+          (api_values->GetList(i, &permission_list) &&
+           permission_list->GetString(0, &permission_name))) {
         APIPermission *permission = info->GetByName(permission_name);
-        if (permission)
-          apis.insert(permission->id());
+        if (permission) {
+          Value* tmp = NULL;
+          if (!permission_list || !permission_list->Get(1, &tmp))
+            tmp = NULL;

[miket_OOO, 2012/07/31 18:18:37]

Does permission_list->Get() change the Value yet also return failure? If so,
it's a weird function. If not, the tmp = NULL is a no-op.

[Peng, 2012/07/31 19:32:28]

Done. I checked ListValue::Get() the tmp will be unchanged, if it returns false.

+          scoped_refptr<APIPermissionDetail> detail =
+            permission->CreateDetail();
+          detail->FromValue(tmp);

[miket_OOO, 2012/07/31 18:18:37]

Does this work if tmp is NULL? Should we even be adding a null detail?

[Peng, 2012/07/31 19:32:28]

Done.

+          apis.insert(detail);
+        }
       }
     }
   }
 
   // Retrieve the explicit host permissions.
   URLPatternSet explicit_hosts;
   ReadExtensionPrefURLPatternSet(
       extension_id, JoinPrefs(pref_key, kPrefExplicitHosts),
       &explicit_hosts, Extension::kValidHostPermissionSchemes);
 
   // Retrieve the scriptable host permissions.
   URLPatternSet scriptable_hosts;
   ReadExtensionPrefURLPatternSet(
       extension_id, JoinPrefs(pref_key, kPrefScriptableHosts),
       &scriptable_hosts, UserScript::kValidUserScriptSchemes);
 
   return new PermissionSet(apis, explicit_hosts, scriptable_hosts);
 }
 
 void ExtensionPrefs::SetExtensionPrefPermissionSet(
     const std::string& extension_id,
     const std::string& pref_key,
     const PermissionSet* new_value) {
   // Set the API permissions.
   ListValue* api_values = new ListValue();
   APIPermissionSet apis = new_value->apis();
-  PermissionsInfo* info = PermissionsInfo::GetInstance();
   std::string api_pref = JoinPrefs(pref_key, kPrefAPIs);
   for (APIPermissionSet::const_iterator i = apis.begin();
        i != apis.end(); ++i) {
-    APIPermission* perm = info->GetByID(*i);
-    if (perm)
-      api_values->Append(Value::CreateStringValue(perm->name()));
+    Value* detail = NULL;
+    i->ToValue(&detail);
+    if (!detail) {
+      api_values->Append(Value::CreateStringValue(i->name()));
+    } else {
+      ListValue* tmp = new ListValue();
+      tmp->Append(Value::CreateStringValue(i->name()));
+      tmp->Append(detail);
+      api_values->Append(tmp);
+    }
   }
   UpdateExtensionPref(extension_id, api_pref, api_values);
 
   // Set the explicit host permissions.
   if (!new_value->explicit_hosts().is_empty()) {
     SetExtensionPrefURLPatternSet(extension_id,
                                   JoinPrefs(pref_key, kPrefExplicitHosts),
                                   new_value->explicit_hosts());
   }
 
@@ skipping 1400 matching lines @@
                            0,  // default value
                            PrefService::UNSYNCABLE_PREF);
   prefs->RegisterInt64Pref(prefs::kNextExtensionsUpdateCheck,
                            0,  // default value
                            PrefService::UNSYNCABLE_PREF);
   prefs->RegisterListPref(prefs::kExtensionAllowedInstallSites,
                           PrefService::UNSYNCABLE_PREF);
 }
 
 }  // namespace extensions