Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10692152: Rename gdata_parser to gdata_wapi_parser (Closed)

Created:
8 years, 5 months ago by kochi
Modified:
8 years, 5 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, satorux1
Visibility:
Public.

Description

Rename gdata_parser to gdata_wapi_parser This is for preparation for adding new Drive V2 API parser. BUG=chromium:127728 TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146291

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix for comments. #

Patch Set 3 : rebase and fix merge conflict. #

Patch Set 4 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2189 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_webapps_registry.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_webapps_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_params.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_parser.h View 1 2 1 chunk +0 lines, -701 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_parser.cc View 1 chunk +0 lines, -1056 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_parser_unittest.cc View 1 chunk +0 lines, -402 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_upload_file_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/gdata/gdata_wapi_parser.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/gdata/gdata_wapi_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kochi
Ryo, could you review this? Ben, could you check for owners lgtm? Thanks,
8 years, 5 months ago (2012-07-11 05:35:59 UTC) #1
hashimoto
http://codereview.chromium.org/10692152/diff/1/chrome/browser/chromeos/gdata/gdata_params.h File chrome/browser/chromeos/gdata/gdata_params.h (right): http://codereview.chromium.org/10692152/diff/1/chrome/browser/chromeos/gdata/gdata_params.h#newcode21 chrome/browser/chromeos/gdata/gdata_params.h:21: #include "chrome/browser/chromeos/gdata/gdata_wapi_parser.h" Is this include needed? http://codereview.chromium.org/10692152/diff/1/chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc File chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc ...
8 years, 5 months ago (2012-07-11 06:03:08 UTC) #2
kochi
http://codereview.chromium.org/10692152/diff/1/chrome/browser/chromeos/gdata/gdata_params.h File chrome/browser/chromeos/gdata/gdata_params.h (right): http://codereview.chromium.org/10692152/diff/1/chrome/browser/chromeos/gdata/gdata_params.h#newcode21 chrome/browser/chromeos/gdata/gdata_params.h:21: #include "chrome/browser/chromeos/gdata/gdata_wapi_parser.h" Removed. (instead, we had to include it ...
8 years, 5 months ago (2012-07-11 06:26:32 UTC) #3
hashimoto
lgtm
8 years, 5 months ago (2012-07-11 06:30:57 UTC) #4
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-11 15:59:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10692152/2002
8 years, 5 months ago (2012-07-12 00:36:42 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/gdata/gdata_wapi_parser.h: While running patch -p1 --forward --force; patching file chrome/browser/chromeos/gdata/gdata_wapi_parser.h ...
8 years, 5 months ago (2012-07-12 00:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10692152/6004
8 years, 5 months ago (2012-07-12 04:33:58 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 05:41:55 UTC) #9 
Try job failure for 10692152-6004 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698