Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4340)

Unified Diff: chrome/browser/resources/feedback.js

Issue 10692110: screenshot disabling policy (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed Android and Mac builds Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/feedback.html ('k') | chrome/browser/ui/ash/screenshot_taker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index 92dce859b6975e039b8a497b335157f95e812657..a8da0eba5218f25e6d1545846d38dcbd82bcdaec 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -15,6 +15,7 @@ savedThumbnailIds['current-screenshots'] = '';
savedThumbnailIds['saved-screenshots'] = '';
var categoryTag = '';
+var forceDisableScreenshots = false;
/**
* Selects an image thumbnail in the specified div.
@@ -76,13 +77,10 @@ function addScreenshot(divId, screenshot) {
/**
* Disables screenshots completely.
*/
-function disableScreenshots() {
- $('screenshot-row').hidden = true;
- $('screenshot-checkbox').checked = false;
-
- $('current-screenshots').hidden = true;
- if ($('saved-screenshots'))
- $('saved-screenshots').hidden = true;
+function enableScreenshots() {
+ if (forceDisableScreenshots)
+ return;
+ $('screenshot-row').hidden = false;
}
/**
@@ -240,7 +238,8 @@ function load() {
if (parameters['customPageUrl'] != '') {
$('page-url-text').value = parameters['customPageUrl'];
// and disable the page image, since it doesn't make sense on a custum url.
- disableScreenshots();
+ $('screenshot-checkbox').checked = false;
+ forceDisableScreenshots = true;
}
// Pick up the category tag (for most cases this will be an empty string)
@@ -278,23 +277,27 @@ function setupSavedScreenshots(screenshots) {
}
function setupDialogDefaults(defaults) {
- if (defaults.length > 0) {
- if ($('page-url-text').value == '')
- $('page-url-text').value = defaults[0];
- if (defaults[0] == '')
- $('page-url-checkbox').checked = false;
-
- if (defaults.length > 2) {
- // We're in Chromium OS.
- $('user-email-text').textContent = defaults[2];
- if (defaults[2] == '') {
- // if we didn't get an e-mail address from cros,
- // disable the user email display totally.
- $('user-email-table').hidden = true;
-
- // this also means we are in privacy mode, so no saved screenshots.
- $('screenshot-link-tosaved').hidden = true;
- }
+ // Current url.
+ if ($('page-url-text').value == '')
+ $('page-url-text').value = defaults.currentUrl;
+ if (defaults.currentUrl == '')
+ $('page-url-checkbox').checked = false;
+
+ // Are screenshots disabled?
+ if (!defaults.disableScreenshots)
+ enableScreenshots();
+
+ // User e-mail.
+ if ($('user-email-text')) {
+ // We're in Chromium OS.
+ $('user-email-text').textContent = defaults.userEmail;
+ if (defaults.userEmail == '') {
+ // if we didn't get an e-mail address from cros,
+ // disable the user email display totally.
+ $('user-email-table').hidden = true;
+
+ // this also means we are in privacy mode, so no saved screenshots.
+ $('screenshot-link-tosaved').hidden = true;
}
}
}
« no previous file with comments | « chrome/browser/resources/feedback.html ('k') | chrome/browser/ui/ash/screenshot_taker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698