chrome/test/perf/rendering/throughput_tests.cc - Issue 10692110: screenshot disabling policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/perf/rendering/throughput_tests.cc

Issue 10692110: screenshot disabling policy (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Broken screenshot not visible on feedback page when screenshots are disabled Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/perf/rendering/throughput_tests.cc

diff --git a/chrome/test/perf/rendering/throughput_tests.cc b/chrome/test/perf/rendering/throughput_tests.cc

index c488999a0e44842090da382d9ee2785820a995cd..7e9ad6f32ef8a9242ede1e4cad31083686d41db2 100644

--- a/chrome/test/perf/rendering/throughput_tests.cc

+++ b/chrome/test/perf/rendering/throughput_tests.cc

@@ -220,8 +220,9 @@ class ThroughputTest : public BrowserPerfTest {

tab_contents_bounds.height());

gfx::NativeWindow native_window = browser()->window()->GetNativeWindow();

- if (!browser::GrabWindowSnapshot(native_window, &png, snapshot_bounds)) {

- LOG(ERROR) << "browser::GrabWindowSnapShot() failed";

+ if (!browser::GrabWindowSnapshotIfPermitted(native_window, &png,

+ snapshot_bounds)) {

+ LOG(ERROR) << "browser::GrabWindowSnapshotIfPermitted() failed";

return false;

}