screenshot disabling policy

chrome/browser/resources/feedback.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Constants.
 /** @const */ var FEEDBACK_LANDING_PAGE =
     'https://www.google.com/support/chrome/go/feedback_confirmation';
 
 var selectedThumbnailDivId = '';
 var selectedThumbnailId = '';
 var selectedImageUrl;
 
 var savedThumbnailIds = [];
 savedThumbnailIds['current-screenshots'] = '';
 savedThumbnailIds['saved-screenshots'] = '';
 
 var categoryTag = '';
+var forceDisableScreenshots = false;
 
 /**
  * Selects an image thumbnail in the specified div.
  * @param {string} divId The id of the div to search in.
  * @param {string} thumbnailId The id of the thumbnail to search for.
  */
 function selectImage(divId, thumbnailId) {
   var thumbnailDivs = $(divId).children;
   selectedThumbnailDivId = divId;
   if (thumbnailDivs.length == 0) {
@@ skipping 41 matching lines @@
   thumbnailDiv.appendChild(innerDiv);
   $(divId).appendChild(thumbnailDiv);
 
   if (!selectedThumbnailId)
     selectImage(divId, thumbnailDiv.id);
 }
 
 /**
  * Disables screenshots completely.
  */
-function disableScreenshots() {
-  $('screenshot-row').hidden = true;
-  $('screenshot-checkbox').checked = false;

[Mattias Nissler (ping if slow), 2012/07/13 15:23:42]

Why have you removed the updates to screenshot-checkbox, current-screenshots and
saved-screenshots? It seems they would have to be updated as well.

[qfel, 2012/07/16 09:11:12]

saved-screenshots and current-screenshots are inside screenshot-row, so that's
redundant. screenshot-checkbox was unchecked by default and so is now.

-
-  $('current-screenshots').hidden = true;
-  if ($('saved-screenshots'))
-    $('saved-screenshots').hidden = true;
+function enableScreenshots() {
+  if (forceDisableScreenshots)
+    return;
+  $('screenshot-row').hidden = false;
 }
 
 /**
  * Sends the report; after the report is sent, we need to be redirected to
  * the landing page, but we shouldn't be able to navigate back, hence
  * we open the landing page in a new tab and sendReport closes this tab.
  * @return {boolean} True if the report was sent.
  */
 function sendReport() {
   if ($('description-text').value.length == 0) {
@@ skipping 137 matching lines @@
     // For a clean URL, trim the parameters from the hash.
     window.location.hash = window.location.hash.substring(0, queryPos);
   }
 
   // Set the initial description text.
   $('description-text').textContent = parameters['description'];
   // If a page url is spcified in the parameters, override the default page url.
   if (parameters['customPageUrl'] != '') {
     $('page-url-text').value = parameters['customPageUrl'];
     // and disable the page image, since it doesn't make sense on a custum url.
-    disableScreenshots();
+    $('screenshot-checkbox').checked = false;
+    forceDisableScreenshots = true;
   }
 
   // Pick up the category tag (for most cases this will be an empty string)
   categoryTag = parameters['categoryTag'];
 
   chrome.send('getDialogDefaults');
   chrome.send('refreshCurrentScreenshot');
 }
 
 function setupCurrentScreenshot(screenshot) {
@@ skipping 17 matching lines @@
     for (i = 0; i < screenshots.length; ++i)
       addScreenshot('saved-screenshots', screenshots[i]);
 
     // Now that we have our screenshots, try selecting the saved screenshots
     // again.
     savedSelected();
   }
 }
 
 function setupDialogDefaults(defaults) {
-  if (defaults.length > 0) {
-    if ($('page-url-text').value == '')
-      $('page-url-text').value = defaults[0];
-    if (defaults[0] == '')
-      $('page-url-checkbox').checked = false;
+  // 0: current url
+  if (defaults.length <= 0)
+    return;
+  if ($('page-url-text').value == '')
+    $('page-url-text').value = defaults[0];
+  if (defaults[0] == '')
+    $('page-url-checkbox').checked = false;
 
-    if (defaults.length > 2) {
-      // We're in Chromium OS.
-      $('user-email-text').textContent = defaults[2];
-      if (defaults[2] == '') {
-        // if we didn't get an e-mail address from cros,
-        // disable the user email display totally.
-        $('user-email-table').hidden = true;
+  // 1: are screenshots disabled?
+  if (defaults.length <= 1)
+    return;
+  if (!defaults[1])
+    enableScreenshots();
 
-        // this also means we are in privacy mode, so no saved screenshots.
-        $('screenshot-link-tosaved').hidden = true;
-      }
-    }
+  // 2: user e-mail
+  if (defaults.length <= 2)
+    return;
+  // We're in Chromium OS.
+  $('user-email-text').textContent = defaults[2];
+  if (defaults[2] == '') {
+    // if we didn't get an e-mail address from cros,
+    // disable the user email display totally.
+    $('user-email-table').hidden = true;
+
+    // this also means we are in privacy mode, so no saved screenshots.
+    $('screenshot-link-tosaved').hidden = true;
   }
 }
 
 window.addEventListener('DOMContentLoaded', load);