Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: webkit/media/buffered_data_source.h

Issue 10692106: Split BufferedResourceLoader's network callback into separate loading state and progress callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix stuff Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/media/buffered_data_source.cc » ('j') | webkit/media/buffered_data_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/buffered_data_source.h
diff --git a/webkit/media/buffered_data_source.h b/webkit/media/buffered_data_source.h
index 15471b2838169d0f980e974a9d3d38e8fd0e097c..61f5e3f09ac3ae327cf44fcee1c2b49d156402cc 100644
--- a/webkit/media/buffered_data_source.h
+++ b/webkit/media/buffered_data_source.h
@@ -139,11 +139,13 @@ class BufferedDataSource : public media::DataSource {
// BufferedResourceLoader lives, i.e. render thread.
void PartialReadStartCallback(BufferedResourceLoader::Status status);
- // Callback method for making a read request to BufferedResourceLoader.
+ // Read callback for BufferedResourceLoader.
void ReadCallback(BufferedResourceLoader::Status status, int bytes_read);
- // Callback method when a network event is received.
- void NetworkEventCallback();
+ // Loading and progress callbacks for HTTP resources.
+ void HttpLoadingStateChangedCallback(
+ BufferedResourceLoader::LoadingState state);
+ void HttpProgressCallback(int64 position);
void UpdateHostState_Locked();
@@ -169,9 +171,6 @@ class BufferedDataSource : public media::DataSource {
// A resource loader for the media resource.
scoped_ptr<BufferedResourceLoader> loader_;
- // True if |loader| is downloading data.
- bool is_downloading_data_;
-
// Callback method from the pipeline for initialization.
media::PipelineStatusCB initialize_cb_;
« no previous file with comments | « no previous file | webkit/media/buffered_data_source.cc » ('j') | webkit/media/buffered_data_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698