Enhance chrome://omnibox Presentation

chrome/browser/autocomplete/autocomplete_match.h

Index: chrome/browser/autocomplete/autocomplete_match.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_match.h	(revision 145689)
+++ chrome/browser/autocomplete/autocomplete_match.h	(working copy)
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_
 #pragma once
 
+#include <map>
 #include <string>
 #include <vector>
 
@@ -18,6 +19,10 @@
 class Profile;
 class TemplateURL;
 
+namespace base {
+class Time;
+}  // namespace base
+
 // AutocompleteMatch ----------------------------------------------------------
 
 // A single result line with classified spans.  The autocomplete popup displays
@@ -190,6 +195,11 @@
   // TemplateURL.  See comments on |keyword| below.
   TemplateURL* GetTemplateURL(Profile* profile) const;
 
+  // Adds logging information to the logging dictionary |info_log|.

[Mark P, 2012/07/10 14:51:34]

Please don't call this type of information (displayed on chrome://omnibox)
logged information.  It's not logged.

This comment requires changes in multiple places in multiple files.

[mrossetti, 2012/07/10 17:57:08]

Excellent suggestion! I want with forms of the word 'diagnostic'. What do you
think?

+  void LogInfo(const std::string& title, const std::string& value);

[Mark P, 2012/07/10 14:51:34]

Title feels to me a bit odd.  Consider something else like name or property or
feature or variable_name or ...

Once you rename this, please change the css/html/js appropriately.

[mrossetti, 2012/07/10 17:57:08]

In this case, I went with 'property'.

+  void LogInfo(const std::string& title, int value);
+  void LogInfo(const std::string& title, const base::Time& value);
+
   // The provider of this match, used to remember which provider the user had
   // selected when the input changes. This may be NULL, in which case there is
   // no provider (or memory of the user's selection).
@@ -284,6 +294,10 @@
   // AutocompleteController to do no additional transformations.
   scoped_ptr<TemplateURLRef::SearchTermsArgs> search_terms_args;
 
+  // Logging information dictionary into which each provider can optionally
+  // include a title as key and associated data.
+  std::map<std::string, std::string> info_log;
+
 #ifndef NDEBUG
   // Does a data integrity check on this match.
   void Validate() const;