Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2799)

Unified Diff: chrome/browser/autocomplete/autocomplete_match.h

Issue 10692075: Enhance chrome://omnibox Presentation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: We\'re not logging\! We\'re recording diagnostics\! Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_match.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_match.h (revision 145893)
+++ chrome/browser/autocomplete/autocomplete_match.h (working copy)
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_
#pragma once
+#include <map>
#include <string>
#include <vector>
@@ -18,6 +19,10 @@
class Profile;
class TemplateURL;
+namespace base {
+class Time;
+} // namespace base
+
// AutocompleteMatch ----------------------------------------------------------
// A single result line with classified spans. The autocomplete popup displays
@@ -190,6 +195,11 @@
// TemplateURL. See comments on |keyword| below.
TemplateURL* GetTemplateURL(Profile* profile) const;
+ // Adds diagnostic information to the |diagnostics| dictionary.
+ void RecordDiagnostic(const std::string& property, const std::string& value);
+ void RecordDiagnostic(const std::string& property, int value);
+ void RecordDiagnostic(const std::string& property, const base::Time& value);
+
// The provider of this match, used to remember which provider the user had
// selected when the input changes. This may be NULL, in which case there is
// no provider (or memory of the user's selection).
@@ -284,6 +294,10 @@
// AutocompleteController to do no additional transformations.
scoped_ptr<TemplateURLRef::SearchTermsArgs> search_terms_args;
+ // Diagnostic information dictionary into which each provider can optionally
+ // record a property and associated value.
Mark P 2012/07/10 19:41:12 Consider adding: Used for chrome://omnibox
mrossetti 2012/07/14 02:34:06 Done.
+ std::map<std::string, std::string> diagnostics;
+
#ifndef NDEBUG
// Does a data integrity check on this match.
void Validate() const;
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_match.cc » ('j') | chrome/browser/resources/omnibox/omnibox.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698