IndexedDB: IPC plumbing for WebKit::WebIDBTransaction::commit()

IndexedDB: IPC plumbing for WebIDBTransaction::commit()

WebKit patch http://webkit.org/b/89379 requires the ability for IDBTransaction front-ends to trigger the commit of transactions, which mandates plumbing of the WebKit::WebIDBTransaction::commit() call through the IPC layers. Nothing exciting in this patch itself.

R=jam@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144778

[jsbell, 2012-06-27 20:03:35]

jam@ - can you take a look? All the indexed_db OWNERS are on vacation.

Note that this requires http://webkit.org/b/90089 to land in WebKit/roll into
Chromium before this can land.

[jsbell, 2012-06-27 20:05:38]

https://chromiumcodereview.appspot.com/10692017/diff/1/content/browser/in_pro...
File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10692017/diff/1/content/browser/in_pro...
content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:77: // FIXME:
Re-enable the following 3 tests after http://webkit.org/b/89379 lands.
These LayoutTests are renamed from transaction-abort-XXX to
transaction-complete-XXX because the referenced WebKit patch changes the
semantics of "empty" transactions from aborting to committing to match the spec.
Disabling so the WK patch can land, then these will be re-enabled.

[jam, 2012-06-27 20:34:16]

lgtm

http://codereview.chromium.org/10692017/diff/1/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (right):

http://codereview.chromium.org/10692017/diff/1/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:77: // FIXME:
Re-enable the following 3 tests after http://webkit.org/b/89379 lands.
nit: chrome style is TODO(jsbell)

http://codereview.chromium.org/10692017/diff/1/content/common/indexed_db/prox...
File content/common/indexed_db/proxy_webidbtransaction_impl.cc (right):

http://codereview.chromium.org/10692017/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbtransaction_impl.cc:55: {
nit: brace bracket on prev line, same for the rest of the file

[jsbell, 2012-06-27 20:40:35]

Thanks, nits fixed.

http://codereview.chromium.org/10692017/diff/1/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (right):

http://codereview.chromium.org/10692017/diff/1/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:77: // FIXME:
Re-enable the following 3 tests after http://webkit.org/b/89379 lands.
On 2012/06/27 20:34:16, John Abd-El-Malek wrote:
> nit: chrome style is TODO(jsbell)

Done. 

// TODO(jsbell): learn how to write pre-submit checks.

http://codereview.chromium.org/10692017/diff/1/content/common/indexed_db/prox...
File content/common/indexed_db/proxy_webidbtransaction_impl.cc (right):

http://codereview.chromium.org/10692017/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbtransaction_impl.cc:55: {
On 2012/06/27 20:34:16, John Abd-El-Malek wrote:
> nit: brace bracket on prev line, same for the rest of the file 

Done, throughout this file and one other instance found by grep.

[commit-bot: I haz the power, 2012-06-28 18:35:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/10692017/6001

[commit-bot: I haz the power, 2012-06-28 19:44:08]

Change committed as 144778