Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: ui/aura/root_window.h

Issue 10690168: Aura: Resize locks with --ui-enable-threaded-compositing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OSX compile fix. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/bench/bench_main.cc ('k') | ui/aura/root_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/root_window.h
diff --git a/ui/aura/root_window.h b/ui/aura/root_window.h
index 7631d96ba4cc11444ce46c69b91b3114ebd3e6b6..2d07627572e4e41ff43dcf66b5b4d865007910d6 100644
--- a/ui/aura/root_window.h
+++ b/ui/aura/root_window.h
@@ -50,31 +50,6 @@ class RootWindow;
class RootWindowHost;
class RootWindowObserver;
-// This class represents a lock on the compositor, that can be used to prevent a
-// compositing pass from happening while we're waiting for an asynchronous
-// event. The typical use case is when waiting for a renderer to produce a frame
-// at the right size. The caller keeps a reference on this object, and drops the
-// reference once it desires to release the lock.
-// Note however that the lock is canceled after a short timeout to ensure
-// responsiveness of the UI, so the compositor tree should be kept in a
-// "reasonable" state while the lock is held.
-// Don't instantiate this class directly, use RootWindow::GetCompositorLock.
-class AURA_EXPORT CompositorLock
- : public base::RefCounted<CompositorLock>,
- public base::SupportsWeakPtr<CompositorLock> {
- private:
- friend class base::RefCounted<CompositorLock>;
- friend class RootWindow;
-
- explicit CompositorLock(RootWindow* root_window);
- ~CompositorLock();
-
- void CancelLock();
-
- RootWindow* root_window_;
- DISALLOW_COPY_AND_ASSIGN(CompositorLock);
-};
-
// RootWindow is responsible for hosting a set of windows.
class AURA_EXPORT RootWindow : public ui::CompositorDelegate,
public ui::CompositorObserver,
@@ -235,9 +210,6 @@ class AURA_EXPORT RootWindow : public ui::CompositorDelegate,
void HoldMouseMoves();
void ReleaseMouseMoves();
- // Creates a compositor lock.
- scoped_refptr<CompositorLock> GetCompositorLock();
-
// Sets if the window should be focused when shown.
void SetFocusWhenShown(bool focus_when_shown);
@@ -262,10 +234,10 @@ class AURA_EXPORT RootWindow : public ui::CompositorDelegate,
// Overridden from ui::CompositorObserver:
virtual void OnCompositingDidCommit(ui::Compositor*) OVERRIDE;
- virtual void OnCompositingWillStart(ui::Compositor*) OVERRIDE;
virtual void OnCompositingStarted(ui::Compositor*) OVERRIDE;
virtual void OnCompositingEnded(ui::Compositor*) OVERRIDE;
virtual void OnCompositingAborted(ui::Compositor*) OVERRIDE;
+ virtual void OnCompositingLockStateChanged(ui::Compositor*) OVERRIDE;
// Overridden from ui::LayerDelegate:
virtual void OnDeviceScaleFactorChanged(float device_scale_factor) OVERRIDE;
@@ -285,7 +257,6 @@ class AURA_EXPORT RootWindow : public ui::CompositorDelegate,
private:
friend class Window;
- friend class CompositorLock;
// Called whenever the mouse moves, tracks the current |mouse_moved_handler_|,
// sending exited and entered events as its value changes.
@@ -361,9 +332,6 @@ class AURA_EXPORT RootWindow : public ui::CompositorDelegate,
// current mouse location.
void SynthesizeMouseMoveEvent();
- // Called by CompositorLock.
- void UnlockCompositor();
-
scoped_ptr<ui::Compositor> compositor_;
scoped_ptr<RootWindowHost> host_;
@@ -410,9 +378,6 @@ class AURA_EXPORT RootWindow : public ui::CompositorDelegate,
scoped_ptr<ui::ViewProp> prop_;
- CompositorLock* compositor_lock_;
- bool draw_on_compositor_unlock_;
-
DISALLOW_COPY_AND_ASSIGN(RootWindow);
};
« no previous file with comments | « ui/aura/bench/bench_main.cc ('k') | ui/aura/root_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698