Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: cc/layer_tree_host.cc

Issue 10690168: Aura: Resize locks with --ui-enable-threaded-compositing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address jamesr@ comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_tree_host.cc
diff --git a/cc/layer_tree_host.cc b/cc/layer_tree_host.cc
index ebc998ed856ed26077d979a67eb4c0e403b75039..b5306e65a3a8bf48105abbf09d5ffdb5aad505a2 100644
--- a/cc/layer_tree_host.cc
+++ b/cc/layer_tree_host.cc
@@ -330,6 +330,9 @@ void LayerTreeHost::didLoseContext()
bool LayerTreeHost::compositeAndReadback(void *pixels, const IntRect& rect)
{
+ // Clear any pending commits.
jamesr 2012/10/23 21:24:34 No, this is definitely not right. You're imposing
jonathan.backer 2012/10/24 16:42:14 Done. Replaced with a DCHECK in ThreadProxy. Enfor
+ setDeferCommits(false);
+
m_triggerIdleUpdates = false;
bool ret = m_proxy->compositeAndReadback(pixels, rect);
m_triggerIdleUpdates = true;
@@ -340,9 +343,23 @@ void LayerTreeHost::finishAllRendering()
{
if (!m_rendererInitialized)
return;
+
+ // Clear any pending commits.
jamesr 2012/10/23 21:24:34 DCHECK, don't handle
jonathan.backer 2012/10/24 16:42:14 Done. Added DCHECK to ThreadProxy.
+ setDeferCommits(false);
+
m_proxy->finishAllRendering();
}
+void LayerTreeHost::setDeferCommits(bool deferCommits)
+{
+ m_proxy->setDeferCommits(deferCommits);
+}
+
+bool LayerTreeHost::deferCommits() const
+{
+ return m_proxy->deferCommits();
+}
+
void LayerTreeHost::renderingStats(RenderingStats* stats) const
{
*stats = m_renderingStats;

Powered by Google App Engine
This is Rietveld 408576698